Re: [png-mng-implement] libpng-1.5.22rc03 and 1.6.17rc03 are available

[Glenn Randers-P. <gl...@gm...>]

On Fri, Mar 20, 2015 at 11:04 PM, Glenn Randers-Pehrson <gl...@gm...>
wrote:

> I've got a patch ready to revert all of the "& 0xff" changes (most of the
> diff from libpng-1.6.16 to libpng-1.6.17beta01).
> I could hand that in to Coverity and see what happens.
>

One Coverity gripe that was legitimate was where we did png_uint_32
something = byte << 24 | ...
The complaint was about possible unintended sign extension, because
png_uint_32 might be wider than
32 bits.  I subjected all bytes to "& 0xff" but maybe only the MSB needed
that.

G