[pmd-devel] [ pmd-Bugs-2780309 ] Property CloseTargets not documented on PMD site
A source code analyzer
Brought to you by:
adangel,
juansotuyo
From: SourceForge.net <no...@so...> - 2009-06-22 14:41:08
|
Bugs item #2780309, was opened at 2009-04-24 11:33 Message generated for change (Settings changed) made by rpelisse You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=479921&aid=2780309&group_id=56262 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending Resolution: None Priority: 5 Private: No Submitted By: Nicolas Dordet (ndox) Assigned to: Romain PELISSE (rpelisse) Summary: Property CloseTargets not documented on PMD site Initial Comment: In PMD, for the rule CloseResource there is an "hidden" property (not documented) named closeTargets. It allow you to close a database connexion by using a database manager for exemple. If this property is not set, you can have a lot of false positive errors. see line 47 : http://pmd.svn.sourceforge.net/viewvc/pmd/tags/pmd/pmd_release_4_2_4/src/net/sourceforge/pmd/rules/CloseResource.java?view=markup It give all it power to this rule so I think it's important to document it. ---------------------------------------------------------------------- Comment By: Romain PELISSE (rpelisse) Date: 2009-06-22 16:37 Message: Hi Nicolas, Thanks for your report, I'll take care of this asap... ---------------------------------------------------------------------- Comment By: Conrad (conradarmstrong) Date: 2009-04-24 22:32 Message: Except that... that property doesn't completely work! Please see my detailed description of this and 2 other bugs in CloseResource, in PMD bug# 1964798. I even provided the code for a fix (but I can not directly access the PMD project code base for contributing to it). Unfortunately, 1964798 was closed for some reason -- I think it was just miscommunication. Which is too bad, because I thought my fixes were pretty good (and important). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=479921&aid=2780309&group_id=56262 |