From: Orion P. <or...@co...> - 2011-08-24 22:21:55
|
I'm trying to build PDL-Graphics-PLplot 0.56 against plplot 5.9.8 for Fedora and running into the following: t/plplot_library_tests.t .. 1/? # Failed test 'Output file x01p.svg.1 matches reference C output' # at t/plplot_library_tests.t line 55. # Failed test 'Output file x04p.svg.1 matches reference C output' # at t/plplot_library_tests.t line 55. t/plplot_library_tests.t .. 91/? # Failed test 'Output file x21p.svg.2 matches reference C output' # at t/plplot_library_tests.t line 55. # Failed test 'Output file x21p.svg.3 matches reference C output' # at t/plplot_library_tests.t line 55. t/plplot_library_tests.t .. 105/? # Failed test 'Output file x26p.svg.1 matches reference C output' # at t/plplot_library_tests.t line 55. # Failed test 'Output file x26p.svg.2 matches reference C output' # at t/plplot_library_tests.t line 55. t/plplot_library_tests.t .. 136/? # Failed test 'Output file x28p.svg.2 matches reference C output' # at t/plplot_library_tests.t line 55. # Failed test 'Output file x28p.svg.3 matches reference C output' # at t/plplot_library_tests.t line 55. Output file name is x31p.svg.1 t/plplot_library_tests.t .. 178/? # Looks like you failed 8 tests of 182. t/plplot_library_tests.t .. Dubious, test returned 8 (wstat 2048, 0x800) I can't tell any difference between x01c.svg.1 and x01p.svg.1 by eye, and diff only shows: $ diff ./x01p.svg.1 ./t/ref_svg_c_output/x01c.svg.1 1010c1010 < ><tspan font-family="sans-serif" font-style="normal" font-weight="normal"><tspan font-family="serif" font-style="normal" font-weight="normal">PLplot Example 1 - y=x<tspan dy="-7.785550" font-size="8">2</tspan></tspan></tspan></text> --- > ><tspan font-family="sans-serif" font-style="normal" font-weight="normal"><tspan font-family="serif" font-style="normal" font-weight="normal">PLplot Example 1 - y=x<tspan dy="-6.733449" font-size="8">2</tspan></tspan></tspan></text> 2331c2331 < ><tspan font-family="sans-serif" font-style="normal" font-weight="normal">(x10<tspan dy="-7.785550" font-size="8">-2<tspan dy="7.785550" font-size="11">)</tspan></tspan></tspan></text> --- > ><tspan font-family="sans-serif" font-style="normal" font-weight="normal">(x10<tspan dy="-6.733449" font-size="8">-2<tspan dy="6.733449" font-size="11">)</tspan></tspan></tspan></text> 2360c2360 < ><tspan font-family="sans-serif" font-style="normal" font-weight="normal"><tspan font-family="serif" font-style="normal" font-weight="normal">PLplot Example 1 - y=x<tspan dy="-7.785550" font-size="8">2</tspan></tspan></tspan></text> --- > ><tspan font-family="sans-serif" font-style="normal" font-weight="normal"><tspan font-family="serif" font-style="normal" font-weight="normal">PLplot Example 1 - y=x<tspan dy="-6.733449" font-size="8">2</tspan></tspan></tspan></text> I'm wondering if this is a fatally flawed test setup in that the C example comparisons are pre-generated and shipped with PDL-Graphics-PLplot. I imagine some small differences between Doug's machine and mine would account for the discrepancy. Does this seem correct? -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
From: Orion P. <or...@co...> - 2011-08-24 22:27:40
|
On 08/24/2011 04:21 PM, Orion Poplawski wrote: > I'm wondering if this is a fatally flawed test setup in that the C example > comparisons are pre-generated and shipped with PDL-Graphics-PLplot. I imagine > some small differences between Doug's machine and mine would account for the > discrepancy. Does this seem correct? > To answer my own question, if I compile and run the x01c example on my system I get the same as the perl output, but different then the shipped output. So I think you need to have the test build the C output as well on the testing machine. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
From: Alan W. I. <ir...@be...> - 2011-08-25 00:23:29
|
On 2011-08-24 16:27-0600 Orion Poplawski wrote: > On 08/24/2011 04:21 PM, Orion Poplawski wrote: >> I'm wondering if this is a fatally flawed test setup in that the C example >> comparisons are pre-generated and shipped with PDL-Graphics-PLplot. I imagine >> some small differences between Doug's machine and mine would account for the >> discrepancy. Does this seem correct? >> > > To answer my own question, if I compile and run the x01c example on my system > I get the same as the perl output, but different then the shipped output. So > I think you need to have the test build the C output as well on the testing > machine. I think that is a much better approach for eliminating platform differences from comparisons. That is certainly the approach PLplot uses for ctest and also the test_noninteractive target for comparing C PostScript results with those from other languages. Doug? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Doug H. <dh...@uc...> - 2011-08-25 00:46:49
|
Hi Orion: Thats too bad. I'll look into releasing a new version of PDL-Graphics-PLplot that generates C output instead of storing it as part of the test suite. Regards, Doug dh...@uc... Software Engineer UCAR - COSMIC, Tel. (303) 497-2611 On Wed, 24 Aug 2011, Orion Poplawski wrote: > On 08/24/2011 04:21 PM, Orion Poplawski wrote: >> I'm wondering if this is a fatally flawed test setup in that the C example >> comparisons are pre-generated and shipped with PDL-Graphics-PLplot. I >> imagine >> some small differences between Doug's machine and mine would account for >> the >> discrepancy. Does this seem correct? >> > > To answer my own question, if I compile and run the x01c example on my system > I get the same as the perl output, but different then the shipped output. So > I think you need to have the test build the C output as well on the testing > machine. > > -- > Orion Poplawski > Technical Manager 303-415-9701 x222 > NWRA/CoRA Division FAX: 303-415-9702 > 3380 Mitchell Lane or...@co... > Boulder, CO 80301 http://www.cora.nwra.com > |
From: Orion P. <or...@co...> - 2011-08-25 15:26:40
|
On 08/24/2011 05:49 PM, Doug Hunt wrote: > Hi Orion: Thats too bad. I'll look into releasing a new version of > PDL-Graphics-PLplot that generates C output instead of storing it as part of > the test suite. Thanks! -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
From: Doug H. <dh...@uc...> - 2011-09-02 22:59:02
|
Hi Orion, all: I've just uploaded a new version of PDL-Graphics-PLplot to CPAN (v 0.57) which incorporates some fixes recently merged in from the the PDL source tree and also includes an improved plplot_library_tests.t. This test now compiles and runs the C sources from the plplot examples directory and compares them to the perl equivalent output instead of using canned C output for comparison. This is currently only tested on Linux/Ubuntu! The compiling of these C sources may not work on Windows, for example. Best Regards, Doug Hunt dh...@uc... Software Engineer UCAR - COSMIC, Tel. (303) 497-2611 On Wed, 24 Aug 2011, Orion Poplawski wrote: > On 08/24/2011 04:21 PM, Orion Poplawski wrote: >> I'm wondering if this is a fatally flawed test setup in that the C example >> comparisons are pre-generated and shipped with PDL-Graphics-PLplot. I >> imagine >> some small differences between Doug's machine and mine would account for >> the >> discrepancy. Does this seem correct? >> > > To answer my own question, if I compile and run the x01c example on my system > I get the same as the perl output, but different then the shipped output. So > I think you need to have the test build the C output as well on the testing > machine. > > -- > Orion Poplawski > Technical Manager 303-415-9701 x222 > NWRA/CoRA Division FAX: 303-415-9702 > 3380 Mitchell Lane or...@co... > Boulder, CO 80301 http://www.cora.nwra.com > |
From: Orion P. <or...@co...> - 2011-09-08 16:23:03
|
On 09/02/2011 04:59 PM, Doug Hunt wrote: > Hi Orion, all: I've just uploaded a new version of PDL-Graphics-PLplot to CPAN > (v 0.57) which incorporates some fixes recently merged in from the the PDL > source tree and also includes an improved plplot_library_tests.t. > > This test now compiles and runs the C sources > from the plplot examples directory and compares them to the perl equivalent > output instead of using canned C output for comparison. On Fedora, you need to link the C examples against -lm because the example code uses that library. Not sure the best way to add that to your scheme. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
From: Doug H. <dh...@uc...> - 2011-09-08 17:45:26
|
OK, I'll add -lm by default--I don't think that will hurt anything. I also owe Sisyphus a window compile update. Regards, Doug dh...@uc... Software Engineer UCAR - COSMIC, Tel. (303) 497-2611 On Thu, 8 Sep 2011, Orion Poplawski wrote: > On 09/02/2011 04:59 PM, Doug Hunt wrote: >> Hi Orion, all: I've just uploaded a new version of PDL-Graphics-PLplot to >> CPAN >> (v 0.57) which incorporates some fixes recently merged in from the the PDL >> source tree and also includes an improved plplot_library_tests.t. >> >> This test now compiles and runs the C sources >> from the plplot examples directory and compares them to the perl equivalent >> output instead of using canned C output for comparison. > > On Fedora, you need to link the C examples against -lm because the example > code uses that library. Not sure the best way to add that to your scheme. > > > -- > Orion Poplawski > Technical Manager 303-415-9701 x222 > NWRA/CoRA Division FAX: 303-415-9702 > 3380 Mitchell Lane or...@co... > Boulder, CO 80301 http://www.cora.nwra.com > |
From: Alan W. I. <ir...@be...> - 2011-09-08 23:51:45
|
On 2011-09-08 11:46-0600 Doug Hunt wrote: > OK, I'll add -lm by default--I don't think that will hurt anything. Hi Doug: With the PLplot cross-platform build system we specifically exclude -lm for the Windows case because (as I understand it) Windows does not have a separate math library. So my guess is -lm could be an issue for your Windows users. Ignore this comment if PDL-Graphics-PLplot is meant to work only on Unix platforms. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Doug H. <dh...@uc...> - 2011-09-08 19:25:11
|
Hi Orion: I just uploaded PDL-Graphics-PLplot version 0.59 to CPAN. This includes adding -lm and Sysiphus's Windows compile patch. Regards, Doug dh...@uc... Software Engineer UCAR - COSMIC, Tel. (303) 497-2611 On Thu, 8 Sep 2011, Doug Hunt wrote: > OK, I'll add -lm by default--I don't think that will hurt anything. > > I also owe Sisyphus a window compile update. > > Regards, > > Doug > > dh...@uc... > Software Engineer > UCAR - COSMIC, Tel. (303) 497-2611 > > On Thu, 8 Sep 2011, Orion Poplawski wrote: > >> On 09/02/2011 04:59 PM, Doug Hunt wrote: >>> Hi Orion, all: I've just uploaded a new version of PDL-Graphics-PLplot to >>> CPAN >>> (v 0.57) which incorporates some fixes recently merged in from the the PDL >>> source tree and also includes an improved plplot_library_tests.t. >>> >>> This test now compiles and runs the C sources >>> from the plplot examples directory and compares them to the perl >>> equivalent >>> output instead of using canned C output for comparison. >> >> On Fedora, you need to link the C examples against -lm because the example >> code uses that library. Not sure the best way to add that to your scheme. >> >> >> -- >> Orion Poplawski >> Technical Manager 303-415-9701 x222 >> NWRA/CoRA Division FAX: 303-415-9702 >> 3380 Mitchell Lane or...@co... >> Boulder, CO 80301 http://www.cora.nwra.com >> > > _______________________________________________ > Perldl mailing list > Pe...@ja... > http://mailman.jach.hawaii.edu/mailman/listinfo/perldl > |
From: Orion P. <or...@co...> - 2011-09-08 20:52:20
|
On 09/08/2011 01:25 PM, Doug Hunt wrote: > Hi Orion: I just uploaded PDL-Graphics-PLplot version 0.59 to CPAN. This > includes adding -lm and Sysiphus's Windows compile patch. Thanks, that gets farther. Next step is that you are assuming that "." in in the user's path, which is not always the case. The below patch fixes. --- PDL-Graphics-PLplot-0.59/t/plplot_library_tests.t.path 2011-09-08 13:04:57.000000000 -0600 +++ PDL-Graphics-PLplot-0.59/t/plplot_library_tests.t 2011-09-08 14:51:05.584271634 -0600 @@ -50,7 +50,7 @@ # Run C version my $devnull = File::Spec->devnull(); - system "a.out -dev svg -o x${num}c.svg -fam > $devnull 2>&1"; + system "./a.out -dev svg -o x${num}c.svg -fam > $devnull 2>&1"; ok ($? == 0, "C code $c_code ran successfully"); # Run perl version With that change the tests pass for me. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
From: Doug H. <dh...@uc...> - 2011-09-08 21:10:20
|
OK! PDL-Graphics-PLplot 0.60 now includes ./a.out --Doug dh...@uc... Software Engineer UCAR - COSMIC, Tel. (303) 497-2611 On Thu, 8 Sep 2011, Orion Poplawski wrote: > On 09/08/2011 01:25 PM, Doug Hunt wrote: >> Hi Orion: I just uploaded PDL-Graphics-PLplot version 0.59 to CPAN. This >> includes adding -lm and Sysiphus's Windows compile patch. > > Thanks, that gets farther. Next step is that you are assuming that "." in in > the user's path, which is not always the case. The below patch fixes. > > --- PDL-Graphics-PLplot-0.59/t/plplot_library_tests.t.path 2011-09-08 > 13:04:57.000000000 -0600 > +++ PDL-Graphics-PLplot-0.59/t/plplot_library_tests.t 2011-09-08 > 14:51:05.584271634 -0600 > @@ -50,7 +50,7 @@ > > # Run C version > my $devnull = File::Spec->devnull(); > - system "a.out -dev svg -o x${num}c.svg -fam > $devnull 2>&1"; > + system "./a.out -dev svg -o x${num}c.svg -fam > $devnull 2>&1"; > ok ($? == 0, "C code $c_code ran successfully"); > > # Run perl version > > > With that change the tests pass for me. > > -- > Orion Poplawski > Technical Manager 303-415-9701 x222 > NWRA/CoRA Division FAX: 303-415-9702 > 3380 Mitchell Lane or...@co... > Boulder, CO 80301 http://www.cora.nwra.com > |
From: Orion P. <or...@co...> - 2011-09-13 21:35:17
|
On 09/02/2011 04:59 PM, Doug Hunt wrote: > Hi Orion, all: I've just uploaded a new version of PDL-Graphics-PLplot to CPAN > (v 0.57) which incorporates some fixes recently merged in from the the PDL > source tree and also includes an improved plplot_library_tests.t. > > This test now compiles and runs the C sources > from the plplot examples directory and compares them to the perl equivalent > output instead of using canned C output for comparison. Okay, I'm running into a interesting failure on i686 only: # Failed test 'Output file x28p.svg.1 matches C output' # at t/plplot_library_tests.t line 65. # Failed test 'Output file x28p.svg.2 matches C output' # at t/plplot_library_tests.t line 65. # Failed test 'Output file x28p.svg.4 matches C output' # at t/plplot_library_tests.t line 65. # Looks like you failed 3 tests of 242. t/plplot_library_tests.t .. The difference in all three are like the following: $ diff x28[cp].svg.1 991c991 < transform="matrix(0.728866 0.165055 -0.000000 -1.000000 222.106388 332.170782)" --- > transform="matrix(0.728866 0.165055 0.000000 -1.000000 222.106388 332.170782)" a difference in the sign of 0. The -0 result appears to be more "correct" in that that is what is present in both the C and perl x86_64 tests. This is pretty baffling to me. Thoughts? -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
From: Alan W. I. <ir...@be...> - 2011-09-13 23:07:51
|
On 2011-09-13 15:35-0600 Orion Poplawski wrote: > On 09/02/2011 04:59 PM, Doug Hunt wrote: >> Hi Orion, all: I've just uploaded a new version of PDL-Graphics-PLplot to CPAN >> (v 0.57) which incorporates some fixes recently merged in from the the PDL >> source tree and also includes an improved plplot_library_tests.t. >> >> This test now compiles and runs the C sources >> from the plplot examples directory and compares them to the perl equivalent >> output instead of using canned C output for comparison. > > Okay, I'm running into a interesting failure on i686 only: > > # Failed test 'Output file x28p.svg.1 matches C output' > # at t/plplot_library_tests.t line 65. > # Failed test 'Output file x28p.svg.2 matches C output' > # at t/plplot_library_tests.t line 65. > # Failed test 'Output file x28p.svg.4 matches C output' > # at t/plplot_library_tests.t line 65. > # Looks like you failed 3 tests of 242. > t/plplot_library_tests.t .. > > The difference in all three are like the following: > > $ diff x28[cp].svg.1 > 991c991 > < transform="matrix(0.728866 0.165055 -0.000000 -1.000000 222.106388 > 332.170782)" > --- > > transform="matrix(0.728866 0.165055 0.000000 -1.000000 222.106388 > 332.170782)" > > > a difference in the sign of 0. The -0 result appears to be more "correct" in > that that is what is present in both the C and perl x86_64 tests. This is > pretty baffling to me. Thoughts? The IEEE floating-point representation allows a signed zero value which the printf family of routines would print out like above. Alternatively, the above result could be the result of rounding of something near zero with the "%10.6f" formatting directive for the printf family. Anyhow, regardless of whether it is a zero or near-zero signed value, you appear to be getting different answers for that sign for different languages which is not too surprising. I am pretty sure I recall from years ago we were having similar "zero" trouble with the PostScript plots we were comparing for different languages. And the solution in that case was to force near-zero answers to zero. So I think this particular svg device just needs to be made more robust against tiny differences like above by doing the same thing for it. Assuming the problem occurs for -dev svg, I would be happy to encourage a fix for that device to make it suitable for such comparisons. I would also encourage exploiting that work by implementing the alternative of using -dev svg comparisons for PLplot's own tests. Those tests (in the plplot_test/test_diff.sh(.in) bash script) are strictly limited to -dev psc results at the moment because all such "zero" issues (and possibly others) have long since been worked out for that device. Of course, another alternative would be for Doug to also use -dev psc for his comparisons, but I hope he doesn't retreat like that and instead continues with -dev svg. After all, (unlike -dev psc) -dev svg is a modern device that does produce good-looking results for all our examples. Therefore, it would be great to start using -dev svg results for all PLplot comparison purposes. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Douglas H. <dh...@uc...> - 2011-09-11 13:22:22
|
Ouch! Sorry about that. (Says agent 86) I'll try again when I'm back in the office tomorrow. Regards, Doug On Sat, 10 Sep 2011, Sisyphus wrote: > > ----- Original Message ----- From: "Doug Hunt" <dh...@uc...> > To: "Orion Poplawski" <or...@co...> > Cc: "Plplot-devel mailing list" <plp...@li...>; > <pe...@ja...> > Sent: Friday, September 09, 2011 7:11 AM > Subject: Re: [Perldl] [Plplot-devel] PDL-Graphics-PLplot 0.56 and plplot > 5.9.8 > > >> OK! PDL-Graphics-PLplot 0.60 now includes ./a.out > > Which breaks Windows again :-) > > In t/plplot_library_tests.t, instead of: > > ################################## > # Run C version > my $devnull = File::Spec->devnull(); > system "./a.out -dev svg -o x${num}c.svg -fam > $devnull 2>&1"; > ################################## > can we have something like: > ################################## > # Run C version > my $devnull = File::Spec->devnull(); > my $dot_slash = $^O =~ /MSWin32/i ? '' : './'; > system "${dot_slash}a.out -dev svg -o x${num}c.svg -fam > $devnull 2>&1"; > ################################## > > That's fine (and tested) on Windows - and looks like it should be fine (but > untested by me) on those systems that want the preceding "./". > > (I don't see there's any need to upload a new release of > PDL::Graphics::PLplot to CPAN, just to fix this problem. I think it can wait > until there are additional changes to make.) > > Cheers, > Rob |
From: Doug H. <dh...@uc...> - 2011-09-12 21:55:08
|
Hi Rob: Now PDL-Graphics-PLplot 0.61 (now on CPAN) includes your logic for getting rid of './' for Windows. I've tested it under Linux/Ubuntu. Regards, Doug dh...@uc... Software Engineer UCAR - COSMIC, Tel. (303) 497-2611 On Sat, 10 Sep 2011, Sisyphus wrote: > > ----- Original Message ----- From: "Doug Hunt" <dh...@uc...> > To: "Orion Poplawski" <or...@co...> > Cc: "Plplot-devel mailing list" <plp...@li...>; > <pe...@ja...> > Sent: Friday, September 09, 2011 7:11 AM > Subject: Re: [Perldl] [Plplot-devel] PDL-Graphics-PLplot 0.56 and plplot > 5.9.8 > > >> OK! PDL-Graphics-PLplot 0.60 now includes ./a.out > > Which breaks Windows again :-) > > In t/plplot_library_tests.t, instead of: > > ################################## > # Run C version > my $devnull = File::Spec->devnull(); > system "./a.out -dev svg -o x${num}c.svg -fam > $devnull 2>&1"; > ################################## > can we have something like: > ################################## > # Run C version > my $devnull = File::Spec->devnull(); > my $dot_slash = $^O =~ /MSWin32/i ? '' : './'; > system "${dot_slash}a.out -dev svg -o x${num}c.svg -fam > $devnull 2>&1"; > ################################## > > That's fine (and tested) on Windows - and looks like it should be fine (but > untested by me) on those systems that want the preceding "./". > > (I don't see there's any need to upload a new release of > PDL::Graphics::PLplot to CPAN, just to fix this problem. I think it can wait > until there are additional changes to make.) > > Cheers, > Rob |