From: Alan W. I. <ir...@be...> - 2009-11-10 16:38:09
Attachments:
plplot-qt.patch
|
Hi Werner: As our C++/Windows expert would you be willing to take a look at this patch? For your convenience I have downloaded it and attached it to this post. The patch is quite small (~10 changed lines), but I don't understand the C++ implications of these suggested changes to allow qt.cpp to build on MSVC 9.0 (2008) so I don't feel competent to apply this patch myself. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ---------- Forwarded message ---------- Date: Tue, 10 Nov 2009 10:38:51 +0000 From: SourceForge.net <no...@so...> To: no...@so... Subject: [Plplot-devel] [ plplot-Patches-2895119 ] qt driver - proper MSVC exports Patches item #2895119, was opened at 2009-11-10 11:38 Message generated for change (Tracker Item Submitted) made by kapelrud You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302915&aid=2895119&group_id=2915 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: André Kapelrud (kapelrud) Assigned to: Nobody/Anonymous (nobody) Summary: qt driver - proper MSVC exports Initial Comment: Compiling plplot with MSVC 9.0 (2008) failed due to some missing/conflicting __declspec() specifiers. There were also a mangled name (C++) of the plD_DEVICE_INFO_qt in qt.cpp. See attached patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302915&aid=2895119&group_id=2915 ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Plplot-devel mailing list Plp...@li... https://lists.sourceforge.net/lists/listinfo/plplot-devel |
From: Werner S. <sm...@ia...> - 2009-11-11 21:14:50
|
Hi Alan, I looked at the patch and it looks more or less ok, but I would like to test it - but this means to compile the whole (at least most of the) qt source on Windows for Visual C++ 2008, since there are no libraries provided by qt for this compiler tool set. I plan to do that next week - such a compilation takes some hours .... I also remember that I already worked on that part of the qt code, but obviously not here on my laptop. Must have been the Desktop computer in work. So I hope to verify this patch next week. Regards, Werner On Nov 10, 2009, at 5:37 PM, Alan W. Irwin wrote: > Hi Werner: > > As our C++/Windows expert would you be willing to take a look at > this patch? > For your convenience I have downloaded it and attached it to this > post. > > The patch is quite small (~10 changed lines), but I don't understand > the C++ > implications of these suggested changes to allow qt.cpp to build on > MSVC 9.0 > (2008) so I don't feel competent to apply this patch myself. > > Alan > __________________________ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and > Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state > implementation > for stellar interiors (freeeos.sf.net); PLplot scientific plotting > software > package (plplot.org); the libLASi project (unifont.org/lasi); the > Loads of > Linux Links project (loll.sf.net); and the Linux Brochure Project > (lbproject.sf.net). > __________________________ > > Linux-powered Science > __________________________ > > ---------- Forwarded message ---------- > Date: Tue, 10 Nov 2009 10:38:51 +0000 > From: SourceForge.net <no...@so...> > To: no...@so... > Subject: [Plplot-devel] [ plplot-Patches-2895119 ] qt driver - > proper MSVC > exports > > Patches item #2895119, was opened at 2009-11-10 11:38 > Message generated for change (Tracker Item Submitted) made by kapelrud > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=302915&aid=2895119&group_id=2915 > > Please note that this message will contain a full copy of the > comment thread, > including the initial issue submission, for this request, > not just the latest update. > Category: None > Group: None > Status: Open > Resolution: None > Priority: 5 > Private: No > Submitted By: André Kapelrud (kapelrud) > Assigned to: Nobody/Anonymous (nobody) > Summary: qt driver - proper MSVC exports > > Initial Comment: > Compiling plplot with MSVC 9.0 (2008) failed due to some missing/ > conflicting __declspec() specifiers. > There were also a mangled name (C++) of the plD_DEVICE_INFO_qt in > qt.cpp. > > See attached patch. > > ---------------------------------------------------------------------- > > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=302915&aid=2895119&group_id=2915 > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Plplot-devel mailing list > Plp...@li... > https://lists.sourceforge.net/lists/listinfo/plplot-devel<plplot- > qt > .patch > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july_______________________________________________ > Plplot-devel mailing list > Plp...@li... > https://lists.sourceforge.net/lists/listinfo/plplot-devel -- Dr. Werner Smekal Institut fuer Angewandte Physik Technische Universitaet Wien Wiedner Hauptstr 8-10 A-1040 Wien Austria DVR-Nr: 0005886 email: sm...@ia... web: http://www.iap.tuwien.ac.at/~smekal phone: +43-(0)1-58801-13463 (office) +43-(0)1-58801-13469 (laboratory) fax: +43-(0)1-58801-13499 |
From: Werner S. <sm...@ia...> - 2009-11-13 21:46:44
|
Hi Alan, I managed to compile qt 4.5.3 with Visual C++ and confirmed the problems addressed in this patch. I applied the patch (slightly modified it) and commited the changes. I closed the patch report. Regards, Werner On Nov 10, 2009, at 5:37 PM, Alan W. Irwin wrote: > Hi Werner: > > As our C++/Windows expert would you be willing to take a look at > this patch? > For your convenience I have downloaded it and attached it to this > post. > > The patch is quite small (~10 changed lines), but I don't understand > the C++ > implications of these suggested changes to allow qt.cpp to build on > MSVC 9.0 > (2008) so I don't feel competent to apply this patch myself. > > Alan > __________________________ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and > Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state > implementation > for stellar interiors (freeeos.sf.net); PLplot scientific plotting > software > package (plplot.org); the libLASi project (unifont.org/lasi); the > Loads of > Linux Links project (loll.sf.net); and the Linux Brochure Project > (lbproject.sf.net). > __________________________ > > Linux-powered Science > __________________________ > > ---------- Forwarded message ---------- > Date: Tue, 10 Nov 2009 10:38:51 +0000 > From: SourceForge.net <no...@so...> > To: no...@so... > Subject: [Plplot-devel] [ plplot-Patches-2895119 ] qt driver - > proper MSVC > exports > > Patches item #2895119, was opened at 2009-11-10 11:38 > Message generated for change (Tracker Item Submitted) made by kapelrud > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=302915&aid=2895119&group_id=2915 > > Please note that this message will contain a full copy of the > comment thread, > including the initial issue submission, for this request, > not just the latest update. > Category: None > Group: None > Status: Open > Resolution: None > Priority: 5 > Private: No > Submitted By: André Kapelrud (kapelrud) > Assigned to: Nobody/Anonymous (nobody) > Summary: qt driver - proper MSVC exports > > Initial Comment: > Compiling plplot with MSVC 9.0 (2008) failed due to some missing/ > conflicting __declspec() specifiers. > There were also a mangled name (C++) of the plD_DEVICE_INFO_qt in > qt.cpp. > > See attached patch. > > ---------------------------------------------------------------------- > > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=302915&aid=2895119&group_id=2915 > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Plplot-devel mailing list > Plp...@li... > https://lists.sourceforge.net/lists/listinfo/plplot-devel<plplot- > qt > .patch > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july_______________________________________________ > Plplot-devel mailing list > Plp...@li... > https://lists.sourceforge.net/lists/listinfo/plplot-devel -- Dr. Werner Smekal Institut fuer Angewandte Physik Technische Universitaet Wien Wiedner Hauptstr 8-10 A-1040 Wien Austria DVR-Nr: 0005886 email: sm...@ia... web: http://www.iap.tuwien.ac.at/~smekal phone: +43-(0)1-58801-13463 (office) +43-(0)1-58801-13469 (laboratory) fax: +43-(0)1-58801-13499 |
From: Alan W. I. <ir...@be...> - 2009-11-14 19:21:37
|
On 2009-11-13 22:46+0100 Werner Smekal wrote: > Hi Alan, > > I managed to compile qt 4.5.3 with Visual C++ and confirmed the problems > addressed in this patch. I applied the patch (slightly modified it) and > commited the changes. I closed the patch report. Thanks, Werner. However, I found the result did not compile on Linux. Here was the error message: In file included from /home/software/plplot_cvs/HEAD/plplot_cmake_qt/bindings/qt_gui/plqt.cpp:34: /home/software/plplot_cvs/HEAD/plplot_cmake_qt/include/qt.h:92: error: invalid use of ‘extern’ in linkage specification That line had a double extern (which I have never heard of). I replaced that with a single extern (revision 10586), that is -extern "C" extern PLDLLIMPEXP_DRIVER_DATA( const char* ) plD_DEVICE_INFO_qt; +extern "C" PLDLLIMPEXP_DRIVER_DATA( const char* ) plD_DEVICE_INFO_qt; and gcc was happy again, and all the qt device tests (done with the newly implemented test_all_qt target accessible if you use -DBUILD_TEST=ON) went fine. Hopefully, the Windows native compiler does not demand the double extern and that was merely a typographical error introduced in the original patch that the Windows native compiler tolerated before. Please let me know it that is the case. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Werner S. <sm...@ia...> - 2009-11-15 13:56:38
|
Hi Alan, > > That line had a double extern (which I have never heard of). I > replaced that > with a single extern (revision 10586), that is > > -extern "C" extern PLDLLIMPEXP_DRIVER_DATA( const char* ) > plD_DEVICE_INFO_qt; > +extern "C" PLDLLIMPEXP_DRIVER_DATA( const char* ) plD_DEVICE_INFO_qt; In that case I think that plD_DEVICE_INFO_qt will be defined in every file which include qt.h, i.e. there will be several copies of the same variable. Since I don't believe that this needs to be exported anyways, I just deleted the line. Compiles on Windows and Mac OS X. Regards, Werner > > and gcc was happy again, and all the qt device tests (done with the > newly > implemented test_all_qt target accessible if you use - > DBUILD_TEST=ON) went > fine. > > Hopefully, the Windows native compiler does not demand the double > extern and > that was merely a typographical error introduced in the original > patch that > the Windows native compiler tolerated before. Please let me know it > that is > the case. > > Alan > __________________________ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and > Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state > implementation > for stellar interiors (freeeos.sf.net); PLplot scientific plotting > software > package (plplot.org); the libLASi project (unifont.org/lasi); the > Loads of > Linux Links project (loll.sf.net); and the Linux Brochure Project > (lbproject.sf.net). > __________________________ > > Linux-powered Science > __________________________ > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Plplot-devel mailing list > Plp...@li... > https://lists.sourceforge.net/lists/listinfo/plplot-devel -- Dr. Werner Smekal Institut fuer Angewandte Physik Technische Universitaet Wien Wiedner Hauptstr 8-10 A-1040 Wien Austria DVR-Nr: 0005886 email: sm...@ia... web: http://www.iap.tuwien.ac.at/~smekal phone: +43-(0)1-58801-13463 (office) +43-(0)1-58801-13469 (laboratory) fax: +43-(0)1-58801-13499 |