From: Rafael L. <rla...@us...> - 2004-02-18 22:40:08
|
The files below are present in the tarball, but I think that they shouldn't because they are automatically generated. Alan, could you please confirm it? After that, I will implement the fixes. bindings/f77/sfstubs.f bindings/f77/configurable.f bindings/tk-x-plat/pkgIndex.tcl examples/f77/x01f.f examples/f77/x02f.f examples/f77/x03f.f examples/f77/x04f.f examples/f77/x05f.f examples/f77/x06f.f examples/f77/x07f.f examples/f77/x08f.f examples/f77/x09f.f examples/f77/x10f.f examples/f77/x11f.f examples/f77/x12f.f examples/f77/x13f.f examples/f77/x15f.f examples/f77/x16af.f examples/f77/x16f.f examples/f77/x17f.f examples/f77/x18f.f examples/python/plplot_python_start.py examples/tcl/tclIndex scripts/plplot-config doc/docbook/bin/api2man.pl doc/docbook/src/plplotdoc.xml doc/docbook/www/index.html.in -- Rafael |
From: Alan W. I. <ir...@be...> - 2004-02-19 02:06:33
|
On 2004-02-18 23:34+0100 Rafael Laboissiere wrote: > The files below are present in the tarball, but I think that they shouldn't > because they are automatically generated. Alan, could you please confirm > it? After that, I will implement the fixes. > > bindings/f77/sfstubs.f > examples/f77/x01f.f > examples/f77/x02f.f > examples/f77/x03f.f > examples/f77/x04f.f > examples/f77/x05f.f > examples/f77/x06f.f > examples/f77/x07f.f > examples/f77/x08f.f > examples/f77/x09f.f > examples/f77/x10f.f > examples/f77/x11f.f > examples/f77/x12f.f > examples/f77/x13f.f > examples/f77/x15f.f > examples/f77/x16af.f > examples/f77/x16f.f > examples/f77/x17f.f > examples/f77/x18f.f > examples/tcl/tclIndex I confirm the above all generated by make so they should not be in the tarball. > bindings/f77/configurable.f > bindings/tk-x-plat/pkgIndex.tcl > examples/python/plplot_python_start.py > scripts/plplot-config > doc/docbook/bin/api2man.pl > doc/docbook/src/plplotdoc.xml > doc/docbook/www/index.html.in I confirm the above are all generated by ./configure (see configure.ac) so they should not be in the tarball. Thanks, Rafael, for sorting this out. Alan __________________________ Alan W. Irwin email: ir...@be... phone: 250-727-2902 Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the PLplot scientific plotting software package (plplot.org), the Yorick front-end to PLplot (yplot.sf.net), the Loads of Linux Links project (loll.sf.net), and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Arjen M. <arj...@wl...> - 2004-02-19 07:38:39
|
"Alan W. Irwin" wrote: > > On 2004-02-18 23:34+0100 Rafael Laboissiere wrote: > > > The files below are present in the tarball, but I think that they shouldn't > > because they are automatically generated. Alan, could you please confirm > > it? After that, I will implement the fixes. > > > > bindings/f77/sfstubs.f > > examples/f77/x01f.f > > examples/f77/x02f.f > > examples/f77/x03f.f > > examples/f77/x04f.f > > examples/f77/x05f.f > > examples/f77/x06f.f > > examples/f77/x07f.f > > examples/f77/x08f.f > > examples/f77/x09f.f > > examples/f77/x10f.f > > examples/f77/x11f.f > > examples/f77/x12f.f > > examples/f77/x13f.f > > examples/f77/x15f.f > > examples/f77/x16af.f > > examples/f77/x16f.f > > examples/f77/x17f.f > > examples/f77/x18f.f > > examples/tcl/tclIndex > > I confirm the above all generated by make so they should not be in the tarball. > > > bindings/f77/configurable.f > > bindings/tk-x-plat/pkgIndex.tcl > > examples/python/plplot_python_start.py > > scripts/plplot-config > > doc/docbook/bin/api2man.pl > > doc/docbook/src/plplotdoc.xml > > doc/docbook/www/index.html.in > > I confirm the above are all generated by ./configure (see configure.ac) so > they should not be in the tarball. > > Thanks, Rafael, for sorting this out. > Hm, is that the case on Windows too, as we can not run configure there and do not have the m4 preprocessor? (Unless the user has installed Cygwin etc.) I will have to check this ... Regards, Arjen |
From: Alan W. I. <ir...@be...> - 2004-02-19 08:12:48
|
On 2004-02-19 08:32+0100 Arjen Markus wrote: > "Alan W. Irwin" wrote: > > > > > > bindings/f77/sfstubs.f > > > examples/f77/x01f.f .... > > > examples/f77/x18f.f > > > > I confirm the above all generated by make so they should not be in the tarball. > > Hm, is that the case on Windows too, as we can not run configure there > and > do not have the m4 preprocessor? > (Unless the user has installed Cygwin etc.) > > I will have to check this ... Remember that on the Unix/Linux side, the above *.f files are generated from *.fm4 source files either by cp (default double precision) or sed (single precision filtering). The fm4 suffix for the source fortran files is just a historical artifact and m4 is not used any more for generation of these files. If the sys/win32/msdev version of PLplot is always double precision then all you would have to do is copy the *.fm4 forms. But I cannot find any fortran examples infrastructure in sys/win32/msdev so I suspect you haven't implemented fortran examples yet (at least for checked-in code). Alan __________________________ Alan W. Irwin email: ir...@be... phone: 250-727-2902 Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the PLplot scientific plotting software package (plplot.org), the Yorick front-end to PLplot (yplot.sf.net), the Loads of Linux Links project (loll.sf.net), and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Arjen M. <arj...@wl...> - 2004-02-19 08:43:13
|
"Alan W. Irwin" wrote: > > On 2004-02-19 08:32+0100 Arjen Markus wrote: > > > "Alan W. Irwin" wrote: > > > > > > > > bindings/f77/sfstubs.f > > > > examples/f77/x01f.f > .... > > > > examples/f77/x18f.f > > > > > > > I confirm the above all generated by make so they should not be in the tarball. > > > > Hm, is that the case on Windows too, as we can not run configure there > > and > > do not have the m4 preprocessor? > > (Unless the user has installed Cygwin etc.) > > > > I will have to check this ... > > Remember that on the Unix/Linux side, the above *.f files are generated from > *.fm4 source files either by cp (default double precision) or sed (single > precision filtering). The fm4 suffix for the source fortran files is just a > historical artifact and m4 is not used any more for generation of these > files. > > If the sys/win32/msdev version of PLplot is always double precision then all > you would have to do is copy the *.fm4 forms. But I cannot find any fortran > examples infrastructure in sys/win32/msdev so I suspect you haven't > implemented fortran examples yet (at least for checked-in code). > No, but I have done some work there - the examples run smoothly, except for disconcerting messages from the linker (solving that is fairly high priority as they are very annoying!) The current system presumes double precision, so no sed processing is actually required ... Regards, Arjen |
From: Alan W. I. <ir...@be...> - 2004-02-19 09:10:08
|
On 2004-02-19 09:36+0100 Arjen Markus wrote: > "Alan W. Irwin" wrote: > > > > > > > > > > bindings/f77/sfstubs.f > > > > > examples/f77/x01f.f > > .... > > > > > examples/f77/x18f.f > > > > > > > > > > I confirm the above all generated by make so they should not be in the tarball. > The current (sys/win32/msdev) system presumes double precision, so no sed processing is > actually required ... OK, Rafael, that answers the question, and you can go ahead and remove the *.f files from the tarball (and they rest I mentioned as well). Alan __________________________ Alan W. Irwin email: ir...@be... phone: 250-727-2902 Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the PLplot scientific plotting software package (plplot.org), the Yorick front-end to PLplot (yplot.sf.net), the Loads of Linux Links project (loll.sf.net), and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Rafael L. <rla...@us...> - 2004-02-19 12:31:00
|
* Alan W. Irwin <ir...@be...> [2004-02-19 01:04]: > OK, Rafael, that answers the question, and you can go ahead and remove > the *.f files from the tarball (and they rest I mentioned as well). I revisited this issue and noticed that the generation of all mentioned files depend on variables determined at configure time (for instance, the transformation *.fm4 -> *.f depends on with_double). This means that those files must absolutely be kept out of the tarball, otherwise they will propagate the (probably wrong from user's perspective) configuration values chosen by the tarball maker. I will fix this soon. -- Rafael |
From: Arjen M. <arj...@wl...> - 2004-02-19 12:39:21
|
Rafael Laboissiere wrote: > > * Alan W. Irwin <ir...@be...> [2004-02-19 01:04]: > > > OK, Rafael, that answers the question, and you can go ahead and remove > > the *.f files from the tarball (and they rest I mentioned as well). > > I revisited this issue and noticed that the generation of all mentioned > files depend on variables determined at configure time (for instance, the > transformation *.fm4 -> *.f depends on with_double). > > This means that those files must absolutely be kept out of the tarball, > otherwise they will propagate the (probably wrong from user's perspective) > configuration values chosen by the tarball maker. > > I will fix this soon. > That means that if you change the double/single option (by defining or undefining PL_DOUBLE) and then re-make the library, the Fortran examples are not influenced ... Sounds a bit awkward to me. This should be properly documented. Regards, Arjen |
From: Rafael L. <rla...@us...> - 2004-02-19 21:53:34
|
* Arjen Markus <arj...@wl...> [2004-02-19 13:32]: > That means that if you change the double/single option (by defining or > undefining PL_DOUBLE) and then re-make the library, the Fortran examples > are not influenced ... Sounds a bit awkward to me. This should be properly > documented. Or properly fixed, as I just tried to do with my recent CVS commit. I added dependencies on $(top_builddir)/config.status to the all the x??f.f files, such that each time configure is rerun, those files will be regenerated. There may be instances of the same problem in other Makefile.am's. I am to tired now to investigate this. -- Rafael |
From: Alan W. I. <ir...@be...> - 2004-02-19 17:29:11
|
On 2004-02-19 13:25+0100 Rafael Laboissiere wrote: > * Alan W. Irwin <ir...@be...> [2004-02-19 01:04]: > > > OK, Rafael, that answers the question, and you can go ahead and remove > > the *.f files from the tarball (and they rest I mentioned as well). > > I revisited this issue and noticed that the generation of all mentioned > files depend on variables determined at configure time (for instance, the > transformation *.fm4 -> *.f depends on with_double). > > This means that those files must absolutely be kept out of the tarball, > otherwise they will propagate the (probably wrong from user's perspective) > configuration values chosen by the tarball maker. > > I will fix this soon. Good catch, Rafael! I agree this is a definite bug in 5.3.0. I believe we have received no complaints about it only because it is so rare for single precision (or other non-default configuration items that cause the generation of the files you have brought to our attention) to be used. Alan __________________________ Alan W. Irwin email: ir...@be... phone: 250-727-2902 Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the PLplot scientific plotting software package (plplot.org), the Yorick front-end to PLplot (yplot.sf.net), the Loads of Linux Links project (loll.sf.net), and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Rafael L. <rla...@us...> - 2004-02-19 08:04:06
|
* Arjen Markus <arj...@wl...> [2004-02-19 08:32]: > "Alan W. Irwin" wrote: > > > > On 2004-02-18 23:34+0100 Rafael Laboissiere wrote: > > > > > The files below are present in the tarball, but I think that they shouldn't > > > because they are automatically generated. Alan, could you please confirm > > > it? After that, I will implement the fixes. > > > > > > bindings/f77/sfstubs.f > > > examples/f77/x01f.f > > > examples/f77/x02f.f > > > examples/f77/x03f.f > > > examples/f77/x04f.f > > > examples/f77/x05f.f > > > examples/f77/x06f.f > > > examples/f77/x07f.f > > > examples/f77/x08f.f > > > examples/f77/x09f.f > > > examples/f77/x10f.f > > > examples/f77/x11f.f > > > examples/f77/x12f.f > > > examples/f77/x13f.f > > > examples/f77/x15f.f > > > examples/f77/x16af.f > > > examples/f77/x16f.f > > > examples/f77/x17f.f > > > examples/f77/x18f.f > > > examples/tcl/tclIndex > > > > I confirm the above all generated by make so they should not be in the tarball. > > > > > bindings/f77/configurable.f > > > bindings/tk-x-plat/pkgIndex.tcl > > > examples/python/plplot_python_start.py > > > scripts/plplot-config > > > doc/docbook/bin/api2man.pl > > > doc/docbook/src/plplotdoc.xml > > > doc/docbook/www/index.html.in > > > > I confirm the above are all generated by ./configure (see configure.ac) so > > they should not be in the tarball. > > > > Thanks, Rafael, for sorting this out. > > > > Hm, is that the case on Windows too, as we can not run configure there > and > do not have the m4 preprocessor? > (Unless the user has installed Cygwin etc.) Very good point. If they are really needed in the tarball for Windows users (like, e.g. the swig generated files), then they should not get cleaned by "make clean". We will have to implement one of this: either removing them from the tarball or from CLEANFILES. Alan? -- Rafael |
From: Alan W. I. <ir...@be...> - 2004-02-19 08:16:10
|
On 2004-02-19 08:58+0100 Rafael Laboissiere wrote: > > Hm, is that the case on Windows too, as we can not run configure there > > and > > do not have the m4 preprocessor? > > (Unless the user has installed Cygwin etc.) > > Very good point. If they are really needed in the tarball for Windows users > (like, e.g. the swig generated files), then they should not get cleaned by > "make clean". We will have to implement one of this: either removing them > from the tarball or from CLEANFILES. Alan? I don't think it is a problem (see my previous post which was simultanous with yours), but let's see how Arjen responds to my previous post. Alan __________________________ Alan W. Irwin email: ir...@be... phone: 250-727-2902 Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the PLplot scientific plotting software package (plplot.org), the Yorick front-end to PLplot (yplot.sf.net), the Loads of Linux Links project (loll.sf.net), and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |