RE: [Plib-devel] C++ syntax in puValue.cxx

[Fay J. F C. AAC/W. <joh...@eg...>]

Chances are excellent that you have indeed found a bug.  Good catch, =
and
thank you very much.
=20
I am pretty sure we have already removed the 80-character limit.  If =
you
look at "puValue.cxx" around line 143 you will find code to expand or
contract the string length as necessary.  I think I remember that the =
string
valuator still had an 80-character limit but I am a little hazy on the
details.

John F. Fay=20
joh...@eg...=20

-----Original Message-----
From: Fr=E9d=E9ric JARDON [mailto:fre...@li...]
Sent: Tuesday, September 09, 2003 12:24 PM
To: pli...@li...
Subject: [Plib-devel] C++ syntax in puValue.cxx


Hi,
I was messing with the pui library when I found this code:
puValue.cxx: line 113, function: pu_value::re_eval()
=20
  else if ( res_bool !=3D NULL )
  {
    integer =3D *res_bool ? 1 : 0 ;
    floater =3D *res_bool ? 1.0f : 0.0f ;
=20
    /*
      Needed for puInput / puLargeInput:
      Do not modify the string value unless necessary
    */
    if ( *res_bool !=3D ( strcmp ( string, "0" ) !=3D 0 ) )
      sprintf ( string, "%d", *res_bool ? "1" : "0" ) ;
=20
    puPostRefresh () ;
  }

=20
I am surprised because sprintf( string, "%d", ...) expects an integer. =
But
the result of: *res_bool ? "1" : "0"  is a const char*. Is this a bug ?
=20
Is there any documentation about the internal of pui ? I would like to
remove the 80 chars limit from puInput. Is this a good/bad idea ?
=20
    Frederic JARDON
=20
=20