#298 Player SVN trunk: true problem

trunk
closed-fixed
Brian Gerkey
player (137)
5
2009-08-07
2009-08-06
Paul Osmialowski
No

The playercommon.h header included by (among others) playerc.h has such
definitions:

#ifndef __cplusplus
#define true 1
#define false 0
#endif

It makes lots of warnings to be thrown while compiling Player client
programs that use other libraries:

In file included from
/root/psg22/include/player-3.0/libplayerc/playerc.h:63,
from untilstalledsql.pgc:1:
/root/psg22/include/player-3.0/libplayercommon/playercommon.h:103:1:
warning: "true" redefined
In file included from untilstalledsql.c:4:
/usr/include/ecpglib.h:20:1: warning: this is the location of the previous
definition
In file included from
/root/psg22/include/player-3.0/libplayerc/playerc.h:63,
from untilstalledsql.pgc:1:
/root/psg22/include/player-3.0/libplayercommon/playercommon.h:104:1:
warning: "false" redefined
In file included from untilstalledsql.c:4:
/usr/include/ecpglib.h:23:1: warning: this is the location of the previous
definition

C compilers does not have these constants. However this
wrong interaction with other libraries is unavoidable if we're defining
commonly used constant names. I don't see any reasonable solution for
that.

Discussion

  • G Biggs
    G Biggs
    2009-08-07

    Fixed in CVS HEAD. Thanks very much for the report.

     
  • G Biggs
    G Biggs
    2009-08-07

    • status: open --> closed-fixed