#285 Bug in player ptz interface in svn trunk

trunk
closed-fixed
Brian Gerkey
player (137)
5
2009-07-17
2009-06-09
Stefan Stiene
No

There is a copy and paste error in the ptz interface

message { DATA, STATE, 1, player_power_data_t };

it should be

message { DATA, STATE, 1, player_ptz_data_t };

addionally I added the option to get the pan tilt as request

/** Request/reply subtype: PANTILT */
message { REQ, PAN_TILT, 6, player_ptz_data_t };

Discussion

  • Stefan Stiene
    Stefan Stiene
    2009-06-09

    Bug in player ptz interface in svn trunk

     
    Attachments
  • G Biggs
    G Biggs
    2009-06-09

    I have fixed the incorrect structure bug. I have not added the new message though, as I'm not sure if we want to duplicate something from a data message in a request as well. I'll let others weigh in on that first.

     
  • Toby Collett
    Toby Collett
    2009-07-17

    If you would like additions to the interface, please submit a patch with justification and that also adds relevant access methods to the client libraries.

     
  • Toby Collett
    Toby Collett
    2009-07-17

    • status: open --> closed-fixed