From: Kenny G. <ken...@us...> - 2007-07-10 22:16:06
|
Update of /cvsroot/planeshift/planeshift/src/server/bulkobjects In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27269/src/server/bulkobjects Modified Files: pscharinventory.cpp Log Message: - Removed bogus call to SetOwningCharacter when adding an item - it was setting the owner even when calling with the test flag, and also resulted in equip scripts being run at the wrong time (exploitable). It's not necessary because CombineStack and UpdateInventoryStatus already ensure that the owner gets set correctly. Index: pscharinventory.cpp =================================================================== RCS file: /cvsroot/planeshift/planeshift/src/server/bulkobjects/pscharinventory.cpp,v retrieving revision 1.55 retrieving revision 1.56 diff -C2 -d -r1.55 -r1.56 *** pscharinventory.cpp 10 Jul 2007 21:08:38 -0000 1.55 --- pscharinventory.cpp 10 Jul 2007 22:16:04 -0000 1.56 *************** *** 610,614 **** bool psCharacterInventory::Add(psItem *&item, bool test, bool stack, INVENTORY_SLOT_NUMBER slot, gemContainer* container) { - item->SetOwningCharacter(owner); if (slot%100<ANY_EMPTY_BULK_SLOT || slot%100>=PSCHARACTER_SLOT_BULK_END) { --- 610,613 ---- |