[Gaim-commits] SF.net SVN: gaim: [17803] trunk/console/gntblist.c

[<ebl...@us...>]

Revision: 17803
          http://svn.sourceforge.net/gaim/?rev=17803&view=rev
Author:   eblanton
Date:     2006-11-21 08:35:51 -0800 (Tue, 21 Nov 2006)

Log Message:
-----------
Prevent dropping a buddy on another buddy from crashing.  There should
probably be some smarter logic here.

Modified Paths:
--------------
    trunk/console/gntblist.c

Modified: trunk/console/gntblist.c
===================================================================
--- trunk/console/gntblist.c	2006-11-21 15:15:20 UTC (rev 17802)
+++ trunk/console/gntblist.c	2006-11-21 16:35:51 UTC (rev 17803)
@@ -1025,10 +1025,18 @@
 	GaimGroup *tg = NULL;
 	GaimContact *tc = NULL;
 
+	/* This target resolution probably needs more clarification; for
+	 * example, if I tag a buddy in a contact, then place on
+	 * another buddy in the same contact, I probably intend to
+	 * place the tagged buddy immediately after (before?) the
+	 * target buddy -- this will simply move the tagged buddy
+	 * within the same contact without reference to position. */
 	if (GAIM_BLIST_NODE_IS_GROUP(target))
 		tg = (GaimGroup*)target;
-	else
+	else if (GAIM_BLIST_NODE_IS_CONTACT(target))
 		tc = (GaimContact*)target;
+	else /* Buddy or Chat */
+		tc = (GaimContact*)target->parent;
 
 	if (ggblist->tagged) {
 		GList *list = ggblist->tagged;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.