From: <dat...@us...> - 2006-11-17 06:12:17
|
Revision: 17767 http://svn.sourceforge.net/gaim/?rev=17767&view=rev Author: datallah Date: 2006-11-16 22:12:17 -0800 (Thu, 16 Nov 2006) Log Message: ----------- Ari Pollak traced down a memory leak to the account menuitems not being cleaned up by gtk_container_remove(). It turns out that there is an additional reference somewhere which is preventing the menuitem from being destroyed - deryni tracked it down to gtk_accel_label_set_accel_widget() in gtk_image_menu_item_new_with_label() - we will be reporting the bug to the GTK folks tomorrow. This fixes the leakage; gtk_widget_destroy() is what really should be used in this situation anyway. Modified Paths: -------------- trunk/gtk/gtkblist.c Modified: trunk/gtk/gtkblist.c =================================================================== --- trunk/gtk/gtkblist.c 2006-11-17 04:31:21 UTC (rev 17766) +++ trunk/gtk/gtkblist.c 2006-11-17 06:12:17 UTC (rev 17767) @@ -5965,8 +5965,7 @@ menuitem = l->data; if (menuitem != gtk_item_factory_get_widget(gtkblist->ift, N_("/Accounts/Add\\/Edit"))) - gtk_container_remove(GTK_CONTAINER(accountmenu), - menuitem); + gtk_widget_destroy(menuitem); } for (accounts = gaim_accounts_get_all(); accounts; accounts = accounts->next) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |