[Gaim-commits] CVS: gaim/src plugin.h,1.46,1.47

[Etan R. <de...@us...>]

Update of /cvsroot/gaim/gaim/src
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv10666

Modified Files:
	plugin.h 
Log Message:
We need to figure this out so that things don't break again. The new plugin
dependency unload code assumed that all plugins would have ids set, this was
true for most plugins, but both the perl and tcl loaders didn't set id for
perl and tcl plugins. And I didn't see any code in my quick looking which
actually verified (m)any parts of the struct.


Index: plugin.h
===================================================================
RCS file: /cvsroot/gaim/gaim/src/plugin.h,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -d -p -r1.46 -r1.47
--- plugin.h	18 Jan 2006 18:21:59 -0000	1.46
+++ plugin.h	22 Jan 2006 07:09:06 -0000	1.47
@@ -66,6 +66,11 @@ typedef enum
  *
  * This is used in the version 2.0 API and up.
  */
+/* TODO We need to figure out exactly what parts of this are required. The
+ * dependent plugin unloading stuff was causing crashes with perl and tcl
+ * plugins because they didn't set ids and the dependency code was requiring
+ * them. Then we need to actually make sure that plugins have all the right
+ * parts before loading them. */
 struct _GaimPluginInfo
 {
 	unsigned int magic;