[Gaim-commits] CVS: gaim/src/protocols/gg gg.c,1.172,1.173

[Richard L. <rl...@us...>]

Update of /cvsroot/gaim/gaim/src/protocols/gg
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20347/protocols/gg

Modified Files:
	gg.c 
Log Message:
A change from Bartosz Oler. I think this is intended to hide blocked as a status that one can set on themself. Anyway, this is all wrong, so I added some comments to that effect.

Index: gg.c
===================================================================
RCS file: /cvsroot/gaim/gaim/src/protocols/gg/gg.c,v
retrieving revision 1.172
retrieving revision 1.173
diff -u -d -p -r1.172 -r1.173
--- gg.c	22 Dec 2005 17:16:57 -0000	1.172
+++ gg.c	23 Dec 2005 12:02:01 -0000	1.173
@@ -1452,9 +1452,10 @@ static GList *ggp_status_types(GaimAccou
 			NULL);
 	types = g_list_append(types, type);
 
-	/* Why is blocked a status??? -- rlaager */
+	/* This status is wrong.  It shouldn't exist.  This prpl must not be
+	 * using the privacy stuff correctly. -- rlaager */
 	type = gaim_status_type_new_with_attrs(
-			GAIM_STATUS_INVISIBLE, "blocked", _("Blocked"), TRUE, TRUE, FALSE,
+			GAIM_STATUS_INVISIBLE, "blocked", _("Blocked"), TRUE, FALSE, FALSE,
 			"message", _("Message"), gaim_value_new(GAIM_TYPE_STRING), NULL);
 	types = g_list_append(types, type);
 
@@ -1475,6 +1476,9 @@ static GList *ggp_blist_node_menu(GaimBl
 					 ggp_bmenu_add_to_chat, NULL, NULL);
 	m = g_list_append(m, act);
 
+	/* Using a blist node boolean here is also wrong.
+	 * Once the Block and Unblock actions are added to the core,
+	 * this will have to go. -- rlaager */
 	if (gaim_blist_node_get_bool(node, "blocked")) {
 		act = gaim_blist_node_action_new(_("Unblock"),
 						 ggp_bmenu_block, NULL, NULL);