[Gaim-commits] CVS: gaim/src gtkconv.c,1.522,1.523

[Luke S. <lsc...@us...>]

Update of /cvsroot/gaim/gaim/src
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv18032/src

Modified Files:
	gtkconv.c 
Log Message:
(09:14:16) LSchiere2: um, my new tabs are appearing on the wrong size
(09:14:20) LSchiere2: s/size/side/
(09:14:24) LSchiere2: and i can't drag and drop them
(09:15:01) SeanEgn: Unimportant! It's coming out ;)
(09:15:11) SeanEgn: But, yeah, the wrong size was just a silly mistake
(09:17:07) LSchiere2: and control-tab is backwards also
(09:17:28) SeanEgn: well, actually ctrl-tab is the correct direction.
(09:17:40) SeanEgn: But because the tabs are in the wrong direction, it
seems to go the wrong way.
(09:17:52) SeanEgn: But it does indeed go from tab 0 to tab 1 to tab 2.
(09:18:06) LSchiere2: i see
(09:19:29) SeanEgn: Actually, it might be a GTK bug
(09:20:06) LSchiere2: i am displeased
(09:20:13) SeanEgn: but if you change GTK_PACK_END to GTK_PACK_START, in
gtk_notebook_set_tab_label_packing(), it should probably change.
(09:20:17) LSchiere2: on a side note, i do not remember gtk being in the
list of upgraded packages
(09:20:23) SeanEgn: I would assume the way we want it is _END
(09:20:44) SeanEgn: no, it's new code that I added that's causing this.
(09:21:00) LSchiere2: which file?
(09:21:04) SeanEgn: The "bug" is symantic. I would expect GTK_PACK_END to
pack new tabs to the right of everything.
(09:21:05) SeanEgn: gtkconv.c
(09:21:16) SeanEgn: because that's what packing in the end ususally does.
(09:21:25) SeanEgn: here it seems to pack to the left of everything.


Index: gtkconv.c
===================================================================
RCS file: /cvsroot/gaim/gaim/src/gtkconv.c,v
retrieving revision 1.522
retrieving revision 1.523
diff -u -d -p -r1.522 -r1.523
--- gtkconv.c	29 Jan 2005 22:31:02 -0000	1.522
+++ gtkconv.c	31 Jan 2005 14:36:26 -0000	1.523
@@ -4481,7 +4481,7 @@ gaim_gtk_add_conversation(GaimConvWindow
 
 	/* Add this pane to the conversation's notebook. */
 	gtk_notebook_append_page_menu(GTK_NOTEBOOK(gtkwin->notebook), tab_cont, tabby, menu_tabby);
-	gtk_notebook_set_tab_label_packing(GTK_NOTEBOOK(gtkwin->notebook), tab_cont, TRUE, TRUE, GTK_PACK_END);
+	gtk_notebook_set_tab_label_packing(GTK_NOTEBOOK(gtkwin->notebook), tab_cont, TRUE, TRUE, GTK_PACK_START);
 
 
 	gtk_widget_show(tab_cont);