From: John B. <rek...@re...> - 2006-09-26 15:08:31
|
> I think using a GSList of GaimProxyConnectData is a bad idea. > I do not see why you need to keep a list of GaimProxyConnectData. > > Could you describe the problem (crash)? > > I was looking the other day to this web page: > http://www.artima.com/weblogs/viewpost.jsp?thread=168511 > and saw this inside yahoo_buddy_icon_upload_connected(): > if (!d) > return; > That seems like bad code. This is hardly bad code. It is a simple check to return from the function if d is null and is needed because it is possible NOT to have a buddy icon to send to the server. It makes far more sense to have the null check in this function than to check for null everywhere the function is called, which would be the alternative. John |