From: Kevin M S. <ke...@si...> - 2005-12-01 07:03:50
|
Mark Doliner wrote: > On Wed, 30 Nov 2005 20:40:43 -0500 (EST), Adil wrote >> --- Mark Doliner <the...@us...> wrote: >> >>> Log Message: >>> sf patch #1370473, from Sadrul Habib Chowdhury >>> "This patch fixes the idle time tracking for systems >>> that don't use xscreensaver." >>> >>> Seems like it would just get rid of some warnings? But >>> whatever, definitely an improvement >>> >> For systems that don't use the xscreesaver, gaim_gtk_get_time_idle did= n't >> return anything, causing a compile-warning, and causing the idle-track= ing >> to not work (idle.c:check_idle would get zero and hence not show up=20 >> as idle). >> >> This is one instance where getting rid of a warning message also=20 >> fixes a bug (albeit a very small one). >> >> -- Adil >=20 > Ah, the compile-warning problem didn't occur to me. But there is no > 'check_idle' in idle.c. There is a 'check_idleness', however it should= n't > ever call 'idle_ui_ops->get_time_idle();' when xscreensaver is disabled= > because the idle UI ops are not set when xscreensaver is disabled. Unl= ess I'm > missing something. >=20 > -Mark >=20 Aren't we doing fallback to Gaim idle tracking when xscreensaver is unavailable? Kevin |