Re: [Gaim-devel] [PATCH] Images sending/receiving support for SILC

[Stu T. <st...@no...>]

On Thu, 2005-11-24 at 15:36 +0100, Pekka Riikonen wrote:
> : 1) As you mentioned earlier on this list, there is no way to tell if the
> : img tag was actually text entered by the user or a genuine image tag.
> : 
> : One possible resolution to this would be for the Gaim core to always
> : send html to the prpls, even those that do not set the
> : GAIM_CONNECTION_HTML flag, then the "text only" prpls could scan for img
> : tags before gaim_unescape_html'ing the message themselves. I'm not sure
> : if this is what we want to do though. What do others think?
> : 
> Some generic solution would be nice, but in case of SILC the 
> GAIM_CONNECTION_HTML flag could perhaps be set to get rid of the problem. 

I don't think setting GAIM_CONNECTION_HTML for SILC would be a good
idea, as the UI would then give the impression that message formatting
was supported.

I went ahead and made the change I suggested above, to always send html
from the core, and let prpls do what they want with it.

> However, I still would like to see the IM_IMAGE flag delivered correctly 
> to the prpl, so that there would not have to be message parsing if we know 
> there isn't images.

I did this too, along with removing GaimConvImFlags and
GaimConvChatFlags (we use GaimMessageFlags instead now). We're a bit
closer to image support in chats too.

I've now applied this patch, with my modifications to work with older
SILC Toolkits.

Thanks for the patch!

Regards,


Stu.