From: Tim R. <tim...@co...> - 2005-04-19 10:19:47
|
I did compile with -Wall and did know about all those warnings. Hm well maybe i missed the open comment one. I left those static functions in because i thought maybe gtkconv should be using them, and is doing that stuff by hand. Also, I thought it maybe should be exporting them. Some of the other things I didn't fix because I thought it would need to use the GaimConvWindow api, and I wanted to remove that. In general, the GaimGtkConvwindow api needs to expand, while the GaimConvWindow object needs to be removed. Plugins which need that functionality would then have to be gtk plugins. I was also thinking about GObjectfying those things too. GaimConversation would inherit from GObject, GaimGtkConvWindow would inherit from a top level window i guess, and gtkconv could inherit from gtkconv->tab_cont So, hopefully that explains a few things and where I'm going, so the crazy patch writers can write even crazier patches, and I can be even lazier, etc, --Tim |