Re: [Gaim-devel] Re: [Gaim-commits] CVS: gaim/src gtkblist.c,1.197,1.198 gtknotify.c,1.69,1.70 gtkutils.c,1.96,1.97 notify.c,1.10,1.11 notify.h,1.14,1.15

[Nathan W. <fac...@fa...>]

> If you're correct in the cases you mentined then trust should be FALSE. In
> the case of the trust case for Windows, we are still not doing the right
> thing.. If local files are passed to gaim_notify_uri, they should follow the
> URI file scheme which is currently not the case for the MSN email signon.
> Then, if using ShellExecute, we need to further filter to make sure an
> accpeted URI scheme is used whether trusted or not..  So that part is not
> finished.
> 
> What you havn't addressed is the case of file URIs or new-scheme URIs being
> passed to gaim_notify_uri at the core level, for all platfroms.  With the
> code as it was, we did not distinguish between a URI that came over the
> network (assuming it was a URI.. as we did not check), and one that came
> from within gaim.
> 
> Perhaps the alternative I suggested earlier would be more preferable, where
> selected URI schemes are accepted by gaim_notify_uri (excluding the file
> scheme) and where gaim_notify_uri is used only for URIs that come over that
> network.  Then gaim_notify_internal_uri (which allows the file scheme) would
> be used for URIs that are generated from within gaim such as the MSN email
> signon.  There is really no difference, however, other than the splitting
> the job into two functions.. the same decsions still need to be made by
> those using these functions.

If there's something wrong with allowing file: URIs, then yes maybe we 
need to do something like you're talking about, although the only place 
I see a need for it is MSN email notifications, which use 
gaim_notify_emails, so we'd want to add a parameter to that to say 
whether the attached URLs were trusted or not...right now we're trusting 
every URL passed to gaim_notify_emails which is bad.

If there isn't anything wrong with allowing file: URIs (and I've been 
operating under the assumption that there wasn't) then why can't we just 
add file to the list along with http/https/mailto/ftp and skip the 
trusted thing entirely?  No internal gaim-invented URIs would have any 
need for special treatment.