[Phpwiki-talk] Bug fix for removepage.php

[Oliver B. <ob...@de...>]

Hello All,

on Wednesday I posted this, maybe with an improper subject. Would nice to 
have some feedback.

Using PHPWiki 1.3.3, "Remove the page now" says "Someone has edited the 
page!..." or deletes HomePage if the version number of HomePage is 
accidentally identical to the version of the page to be deleted.

Cause: removepage.php looks for the actual page name by using
$request->getArg, therefore in HTTP_POST_VARS when hitting the "Remove the 
page now" button.

But HTTP_POST_VARS does not contain the page name (from the URI), at least 
on my system. So the HomePage is referenced.

To fix it, I inserted another hidden field in the remove form:

HTML::input(array('type' => 'hidden',
                  'name' => 'pagename',
                  'value' => $page->getName())),

It works, but I don't know whether $page->getName() is the best 
approach since I have little knowledge about the interplay of all the 
stuff.

Another possibility could be to merge HTTP_POST_VARS and HTTP_GET_VARS in 
Request(), any comment on this?

Could this relate to the search functions not working on (some?) 
systems whith USE_PATH_INFO=true? There was also missing the name of 
the search page...

Oliver

-- 
Oliver Betz, Muenchen