From: Dan F. <dfr...@cs...> - 2005-04-14 18:43:04
|
Reini Urban wrote: >>90% of the code I took from editpage.php in CVS current of PhpWiki, >>thanks to Reini. The 10% was two changes: >> >>1. Modify the end-user error message to say "Sorry, too many links (more >> than ##)" instead of "conflicts". >>2. Add a configurable parameter SPAM_MAX_EXTERNAL_LINKS. >> >>Below is an approximate patch to editpage.php. Since we are almost a >>year different from Phpwiki, I cannot guarantee that the patch is >>entirely accurate. >> >>Also, I sent this patch to this list awhile ago. Perhaps I should also >>change it in CVS current? >> >> > >I'd rather stay with the hardcoded number of 20 maxlinks. >This sounds useful to me, after a lot of analysis >and I don't want admins to play with that sensible number, >unless they know what they are doing. >Then they can simply fix the source. > > Okay. For us, we have internal (password-protected) wikis, and I thought we might want to set the # of links very high. Of course, we could probably just disable spam protection altogether. >And I want to give shorter and exact answers on typical support questions. >"Don't do more than 20 links in a new page or you are considered a spammer." >sounds better than >"Don't do more than SPAM_MAX_EXTERNAL_LINKS links (ask your administrator >how much exactly ) in a new page or you are considered a spammer." > > For sure you are right. In my code, I print out the actual #, not the constant name. Dan |