From: Dan F <dfr...@cs...> - 2004-03-24 18:41:51
|
Reini Urban wrote: >> a) I attach editpage-patch.txt, a patch based on 1.3.7. Essentially >> it's your changes Reini, except I renamed 'template' to >> 'initial_content_page'. I hope that's okay. Since there are already >> templates in the system, I thought it would be confusing to have 2 >> different things named template. Thus, I propose templates remain the >> .tmpl files. > > > Well, for now I keep the page argument name to "template". hmm. Okay. I'll change mine to "template" then. I'd still prefer "initial_content_page" because I think there may be confusion, but you've done more work on Phpwiki. > >> 2) It still seems useful to have some sort of parameter substitution >> in the initial content. In fact I need it. That's why I changed the >> plugin parser to allow ~ quoting and such. Thus, I can still not use >> the initial_content_page as given in this email. Reini, I was waiting >> for further information from you about what kind of parameter >> substitution is appropriate and how to do it. I am confused. I look >> forward to further info from you. > > > This is also in. (Your 2nd fixed patch, the first was broken) ~ quoting for plugin arguments helps the initial_content CreatePage argument work correct. That is enough for me, thanks. However, I still do not understand how substitution happens if you give a template argument to CreatePage. The code in there now does no substitution in the template text. > So I'm only waiting for your RateThisPage feature. Whoa. Okay, I did not yet understand how you wanted this delivered. I'll now assume you want patch files, and I'll try to make them. In particular, I don't quite understand how to make a patch file if I have a file that's been modified with things you want (e.g., RateThisPage) AND things you don't want. I'll do my best. See my "pseudo-patch" files below. > And I have to look at the Cached_Wikilink issue. I attach two pseudo-patches to create a Cached_UserLink object that seems to solve this issue for me. Two caveats: 1) I have not tested it extensively. 2) I created the patch files by diff -bu, then manually cutting out pieces of those diffs that don't pertain. This might result in patch files that are not quite right. Hopefully they convey the idea. Dan |