[ppa-dev] Re: [ppa-cvs] CVS: webdb functions.php,1.47,1.47.2.1

[Nicola S. <nso...@ti...>]

Alle 21:38, mercoled=C3=AC 10 agosto 2005, Robert Treat ha scritto:
> Index: functions.php
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/phppgadmin/webdb/functions.php,v
> retrieving revision 1.47
> retrieving revision 1.47.2.1
> diff -C2 -d -r1.47 -r1.47.2.1
> *** functions.php	18 Sep 2004 11:59:40 -0000	1.47
> --- functions.php	10 Aug 2005 19:38:35 -0000	1.47.2.1
> ***************
> ...
> --- 523,536 ----=20
>   				'vars'  =3D> array('function' =3D> '+proproto', 'function_oid' =3D>
> 'prooid'), ),
> ! 		   	'privileges' =3D> array(
> ! 		   	    'title' =3D> $lang['strprivileges'],
> ! 		   	    'url'   =3D>
> "privileges.php?{$misc->href}&subject=3Dfunction&", ! 		   	  =20
> 'vars'  =3D> array('function' =3D> '+proproto', 'function_oid' =3D> 'proo=
id'), ),
>   		);
> +
> +         if (!$data->hasFuncPrivs()) {
> + 			array_pop($actions);
> +         }
>

I suggest to replace:

array_pop($actions);

with:

unset($actions['privileges'];

as we do in printTable() (Misc.php) with comments. So if we change the orde=
r=20
of array keys, this line will still be right.

Nicola