From: Mark G. <gi...@cr...> - 2004-06-22 10:08:43
|
Hello folks, I've applied the printTable to everything (I think). Changes since first patch: - Properties action is applied as a link on the first column (can revert back to a 'Properties' button by modifying printTable - see comments) - Callback functions can modify actions. - Replaced almost all tables with a call to printTable. - Also converted some pages to use printTitle too. - clipString function added to clip comments (disabled by default - enable by uncommenting a line a printTable). I believe this gives us a much more flexible architecture, it should be much easier to customize all tables and create new tables. Doing this exercise seems to have uncovered a few inconsistencies with field name mappings (eg $data->tbFields('...')). Some tables use it fully, some partially and others not at all. I'm beginning to wonder why this even exists. Why not just modify the SQL statements to return consistent field names across versions, and scrap the $data->xxFields maps altogether? Please find patch attached. (patch against anon CVS HEAD as of about 10:30am BST 2004-06-22) Cheers -- Mark Gibson <gibsonm |AT| cromwell |DOT| co |DOT| uk> Web Developer & Database Admin Cromwell Tools Ltd. Leicester, England. |