Re: [ppa-dev] Bug in head as of 2012-09-19?

[Karl O. P. <ko...@me...>]

On 09/25/2012 09:57:45 PM, Karl O. Pinc wrote:
> On 09/24/2012 11:00:16 AM, Jehan-Guillaume (ioguix) de Rorthais 
> wrote:
> > On 24/09/2012 17:06, Karl O. Pinc wrote:
> > > Hi,
> > > 
> > > I'm running head as of 2012-09-19 with pg 9.2.0 and got the
> > > following report from a user:
> > > 
> > > ---------------------------<snip>-----------------
> > > I'm having trouble working with my schema.  When I go to import a 
> > > table,
> > > things seem to go smoothly but then all the data columns in my
> > import
> > > file are dumped into a single phppgadmin column called "actions";
> > the
> > > columns I had created in phppgadmin for the data are left empty. 
> > This
> > > happens regardless of whether the import table structure is csv 
> or
> 
> > > text.
> > 
> > 
> > No bug...but again, I'm not sure to understand this report.

The problem is that display.php displays a column heading
"Action" under which buttons are supposed to appear,
even when there's no keys on the table and hence no
buttons appear.

create table foo(id int, data text);
insert into foo(id, data) values (1, 'bar');

Go browse the table.  You'll see an extra "Action" column
heading.

The attached patch fixes the problem.  I took only a localized
look at the code so I can't say whether this is the best
possible fix.  (Should the code really be counting buttons?
Makes sense in context....)


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein