From: SourceForge.net <no...@so...> - 2010-01-24 02:20:17
|
Bugs item #2876418, was opened at 2009-10-11 06:35 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=418980&aid=2876418&group_id=37132 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General Group: 4.2.2 >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Philippe Cloutier (chealer) Assigned to: Robert Treat (xzilla) Summary: SQL error message displayed with variable pitch Initial Comment: The SQL error messages you get when using the SQL window are not displayed correctly. The font is not correct, even if <pre> is used, due to the pre.data CSS selector's font-family definition to a variable-width font (this is trivial to debug with Firebug). This causes the arrow pointing the error to display not quite in line with the place it's intended to be. ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2010-01-24 02:20 Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Robert Treat (xzilla) Date: 2010-01-09 21:23 Message: This turned out to be a little trickier than the proposed fix, which would have monospaced all preformatted text. This didn't look as good wrt things like view definitions, so instead I created a new class specifically for error messages, and changed ppa to output error messages using the new class. Also bumped up the font size so it was legible. Only tested on my laptop with safari, so we may want to tweak the display, but I think this should work going forward. ---------------------------------------------------------------------- Comment By: Robert Treat (xzilla) Date: 2010-01-09 21:23 Message: This issue has been resolved and is currently fixed in GIT. If you wish to acquire the fix, please download the updated code from http://github.com/xzilla/phppgadmin/ Alternatively, you can download a nightly snapshot from: http://phppgadmin.sourceforge.net/ Note that you may have to wait up to 24 hours for the latest GIT changes to appear in the snapshot. ---------------------------------------------------------------------- Comment By: Niraj Bhawnani (nirajb) Date: 2010-01-03 04:37 Message: Note sure if I committed correctly.. I don't use GIT normally, but the commit did appear to go through. I guess it didn't.. Lucida Console is Windows' default fixed width font that's used in Notepad since Windows 2000 or XP. It's more readable than Courier New when the font size is small. Courier New has been available in Windows for a very long time and so is probably more compatible.. It is also a part of the "msttcorefonts" package that contains Microsoft fonts for Linux platforms. DejaVu Sans Mono is a nice Linux monospaced font.. it's got a Wikipedia article if you want to see what it looks like. It's also included in most Linux distros, I think. Definitely is in Ubuntu. Finally if a system doesn't have any of those fonts, it falls back to the system's default monospaced font. So while it may look different on different systems, it's always monospaced. Other font definitions in the CSS file are also similar in style, though none of them are monospaced. For example: arial, tahoma, verdana, helvetica, sans-serif, serif; The first 3 fonts are Windows specific. The next one comes with Macs but is not on Windows by default, then it falls back to system default fonts. ---------------------------------------------------------------------- Comment By: Robert Treat (xzilla) Date: 2010-01-02 18:07 Message: It isn't really clear what you committed or where you committed it, but if it was just changing the font names, can you explain how your fix isn't simply a fix that only works on your computer, likely breaking things for others (I've never heard of Lucidia Console per say, though I would guess there are recommended fixed-width fonts that should be used)? ---------------------------------------------------------------------- Comment By: Robert Treat (xzilla) Date: 2010-01-02 18:07 Message: It isn't really clear what you committed or where you committed it, but if it was just changing the font names, can you explain how your fix isn't simply a fix that only works on your computer, likely breaking things for others (I've never heard of Lucidia Console per say, though I would guess there are recommended fixed-width fonts that should be used)? ---------------------------------------------------------------------- Comment By: Niraj Bhawnani (nirajb) Date: 2009-11-07 10:46 Message: Committed fix to GIT repository ---------------------------------------------------------------------- Comment By: Niraj Bhawnani (nirajb) Date: 2009-11-07 10:21 Message: I attempted to use the GIT repository but it seems it's broken so I don't have access to the latest files but to correct this in the official 4.2.2 release: Change line 360 in themes/default/global.css from: font-family: arial, tahoma, verdana, helvetica, sans-serif, serif; to: font-family: "Lucida Console", "Courier New", "DejaVu Sans Mono", monospace; ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=418980&aid=2876418&group_id=37132 |