Menu

#3904 (ok 4.0.1) Browsing an empty table should not display its Structure

4.0.0
fixed
None
1
2013-06-11
2013-05-02
No

I believe that going to Structure when browsing an empty table was put in place with the intention of showing at least some information, but it's confusing to be redirected to Structure after clicking on Browse.

So we should stay on Browse, with the usual message that the results set is empty.

Discussion

  • Marc Delisle

    Marc Delisle - 2013-05-02
    • summary: Browsing an empty table should not display it's Structure --> Browsing an empty table should not display its Structure
     
  • Jan Brejcha

    Jan Brejcha - 2013-05-02

    I would like to work on this, is it possible? Thanks!

     
  • Jan Brejcha

    Jan Brejcha - 2013-05-02

    I started to work on it, I will post more information this evening.

     
  • Ayush Choubey

    Ayush Choubey - 2013-05-02

    Sir,
    I would like to add a bit more information on to the page

    So i would like to make it this way

    So we should stay on Browse, with the usual message that the results set is empty and display the entire list of table below.

    Because the tables which are empty are of actually little use and user would like to switch tables. Now instead of again selecting database from the navigation panel or top menu he can directly switch the table . This will be more user friendly i guess and will use the entire screen.

    I am attaching a snapshot of what i actually mean.

    The usual messages along with the list of tables in that DB

    I would like your review on it. Thanks

     
  • Madhura Jayaratne

    IMO, it is a bad idea to show the database level content at table level. I feel that showing batabase structure page here would confuse the user.
    This is what i felt. However, other might have different opinions.

     
  • Jan Brejcha

    Jan Brejcha - 2013-05-03

    I implemented the proposed behavior. Please see pull request here: https://github.com/phpmyadmin/phpmyadmin/pull/305 . This is a first time I am doing this so please feel free to correct and advice me if I am doing something wrong.

    As I was doing this, I came up with one question. In case that the table is empty, should the "Browse" tab be still greyed out or not? I did not changed this, but the user is able to click it so it looks a little bit weird to my eyes that is greyed out but still working.

    For complentess I am attaching a screenshot how it looks now when the "browse" on empty table is clicked.

     

    Last edit: Jan Brejcha 2013-05-03
  • Marc Delisle

    Marc Delisle - 2013-05-03

    The tab is greyed out but still working, because phpMyAdmin believes that the table is empty, but it might not be. By the time the page has been displayed, another process might have written some rows to this table.

    But maybe it's too much confusing and we should just not grey these tabs.

     
  • Jan Brejcha

    Jan Brejcha - 2013-05-05

    Yes, in my opinion it could be confusing for the user. But it's up to you to decide so please when you know how it should be done, tell me and I will do it immediately. Or I can just do a second alternative for you to see the result when the tab is not greyed out.

     
  • Marc Delisle

    Marc Delisle - 2013-05-06

    Discussion started on phpmyadmin-devel list.

     
  • Marc Delisle

    Marc Delisle - 2013-05-08
    • assigned_to: Marc Delisle
     
  • Marc Delisle

    Marc Delisle - 2013-05-08
    • summary: Browsing an empty table should not display its Structure --> (ok 4.0.1) Browsing an empty table should not display its Structure
    • status: open --> open-fixed
    • Priority: 5 --> 1
     
  • Marc Delisle

    Marc Delisle - 2013-05-14
    • Status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed