Re: [perfmon2] [PATCH 2/2] perf_events: add event constraints support for Intel processors
Status: Beta
Brought to you by:
seranian
From: Ingo M. <mi...@el...> - 2009-10-09 13:56:15
|
* Stephane Eranian <er...@go...> wrote: > +struct evt_cstr { > + unsigned long idxmsk[BITS_TO_LONGS(X86_PMC_IDX_MAX)]; > + int code; > +}; > + > +#define EVT_CSTR0(c, m) { .code = (c), .idxmsk[0] = (m) } > +#define EVT_CSTR_END { .code = 0, .idxmsk[0] = 0 } > + > +#define for_each_evt_cstr(e, c) \ > + for((e) = (c); (e)->idxmsk[0]; (e)++) Nice patch - but the naming here absolutely sucked, so i changed evt_cstr, idxmsk, CSTR, etc. to something more palatable. Field names and abstractions in Linux code really need to be meaningful, and the code has to be readable and understandable. Wdntusabbrntslkthtinlnx :) Ingo |