Re: [perfmon2] new 2.6.28 perfmon2, libpfm, and pfmon versions available

[stephane e. <er...@go...>]

Vince,

Try poulling both libpfm and pfmon and let me know if you
still get compilation errors.


On Tue, Feb 24, 2009 at 11:39 PM, stephane eranian
<er...@go...> wrote:
> Vince,
>
> On Tue, Feb 24, 2009 at 11:17 PM, Vince Weaver <vi...@cs...> wrote:
>> Hello
>>
>> just two minor problems with the MIPS/r12k support.  Otherwise version 3.8
>> of the utilities seems to be working great for me on MIPS.
>>
>> First a problem with libpfm, on mips libpfm won't compile because
>>   void adjust__pfmlib_sys_base() does not exist.
>>
>> The following patch is needed (note it is just a missing "O" in _ABIO32)
>>
>> --- libpfm-3.8/lib/pfmlib_os_linux.c    2008-11-24 08:47:44.000000000 -0500
>> +++ libpfm-3.8vmw/lib/pfmlib_os_linux.c 2009-02-24 17:09:59.000000000 -0500
>> @@ -165,7 +165,7 @@
>>        }
>>  #endif
>>  }
>> -#elif (_MIPS_SIM == _ABI32) || (_MIPS_SIM == _MIPS_SIM_ABI32)
>> +#elif (_MIPS_SIM == _ABIO32) || (_MIPS_SIM == _MIPS_SIM_ABI32)
>>  static void adjust__pfmlib_sys_base(int version)
>>  {
>>        _pfmlib_sys_base = 4000;
>>
>>
> Sorry about that one. I will apply the fix.
>
>>
>> Also pfmon does not compile, has the following problem:
>>
>> make[1]: Entering directory `/opt/perfmon/pfmon-3.8/pfmon'
>> cc  -g -ggdb -Wall -Werror -D_REENTRANT -I/usr/local/include
>> -DCONFIG_PFMON_MIPS64 -DPFMON_DEBUG -DDATADIR=\"/usr/local/share/pfmon\" -I.
>> -I/usr/include/libelf -D_GNU_SOURCE -DPFMON_DEBUG -g -c pfmon_util_mips64.c
>> pfmon_util_mips64.c: In function pfmon_get_dlopen_hook:
>> pfmon_util_mips64.c:530: error: pfmon_sdesc_t has no member named
>> new_cmdline
>> pfmon_util_mips64.c:535: error: program_options_t has no member named
>> primary_syms
>> cc1: warnings being treated as errors
>> pfmon_util_mips64.c:535: error: passing argument 3 of find_sym_addr makes
>> pointer from integer without a cast
>> pfmon_util_mips64.c:535: error: incompatible type for argument 4 of
>> find_sym_addr
>> pfmon_util_mips64.c:535: error: too few arguments to function find_sym_addr
>>
> I can take care of this.
>
>> I can comment out the call to pfmon_get_dlopen_hook and pfmon builds
>> and runs normally (I have mainly been profiling statically linked programs).
>>  I haven't attempted to track down the correct fix yet.
>>
> I will fix those two and let you know. This way you'll be able to
> validate the changes.
>
> thanks.
>