Re: [perfmon2] Possible typo in perfmon_ctx.c

[stephane e. <er...@go...>]

Corey,

Patch was fixed for both v2 and v3.
Thanks.

On Thu, Jan 29, 2009 at 1:43 AM, stephane eranian
<er...@go...> wrote:
> On Wed, Jan 28, 2009 at 11:25 PM, Corey Ashford
> <cja...@li...> wrote:
>> Hi Stephane,
>>
>> Carl Love and I were looking at the code in pfm_create_context in
>> perfmon_ctx.c today and ran across something that looks like it might be
>> a typo, but could cause some incorrect behavior:
>>
>> At line 210, there is this code:
>>
>>    /*
>>     * check if PMU is usable
>>     */
>>    if (!(ctx->regs.num_pmcs && ctx->regs.num_pmcs)) {
>>             PFM_DBG("no usable PMU registers");
>>             ret = -EBUSY;
>>             goto error_alloc;
>>    }
>>
>> Should that really be num_pmcs && num_pmcs?  or perhaps num_pmcs &&
>> num_pmds?
>
> you are correct!
>
> Will fix that ASAP.
> thanks.
>
>>
>> Regards,
>>
>> - Corey
>>
>> Corey Ashford
>> Software Engineer
>> IBM Linux Technology Center, Linux Toolchain
>> Beaverton, OR
>> 503-578-3507
>> cja...@us...
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by:
>> SourcForge Community
>> SourceForge wants to tell your story.
>> http://p.sf.net/sfu/sf-spreadtheword
>> _______________________________________________
>> perfmon2-devel mailing list
>> per...@li...
>> https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
>>
>