Re: [perfmon2] [PATCH] PFMON_MAX_CPUS patch

[stephane e. <er...@go...>]

Tony,


On Tue, May 13, 2008 at 10:36 PM, Tony Ernst <te...@sg...> wrote:
> Hi,
>
>  The attached patch that sets PFMON_MAX_CPUS based on __CPU_SETSIZE.
>  I thought this had been changed a while ago, but now I see that it's
>  hardcoded to 2048.  Hardcoding it to 2048 will cause it to fail for
>  larger machines.
>
That makes sense. I remember that at the time I changed that it was
hard to figure out
which glibc version was needed to have a stable cpu_set support.

Always bigger.....

>  It makes more sense to set it to __CPU_SETSIZE from glibc, just like
>  other applications do.  On large machines, __CPU_SETSIZE will always
>  be set large enough; otherwise there would be glibc problems.
>

The patch is missing from the message, unfortunately.