From: Michal H. <ms...@gm...> - 2008-05-18 10:24:43
Attachments:
release-prebuild_man.patch
|
Hi, currently, man page is generated during normal make process (by doc/tools/docbook2man.pl script) which makes our make process dependant on perl. Moreover perl is not detected during configure which can silently lead to an empty man page in the end (if perl is not installed). I suggest attached patch which forces man page generation before distribution tarball is created. This solution is easier than perl detection and I find it better also from keep-as-few-dependency-as-possible POV. -- Michal Hocko |
From: Martin P. <ma...@pe...> - 2008-05-21 18:26:13
|
Michal Hocko wrote: > Hi, > > currently, man page is generated during normal make process (by > doc/tools/docbook2man.pl script) which makes our make process dependant > on perl. Moreover perl is not detected during configure which can > silently lead to an empty man page in the end (if perl is not > installed). > > I suggest attached patch which forces man page generation before > distribution tarball is created. This solution is easier than perl > detection and I find it better also from > keep-as-few-dependency-as-possible POV. this patch alone won't solve the issue because: "make doc_man" in doc depends on Makefile.flags in root, generated by configure, but configure is not run when creating the tarball. Command that would do the job would be: pdfedit-$VERSION/tools/docbook2man.pl pdfedit-$VERSION/doc/user/pdfedit.xml >pdfedit-$VERSION/doc/user/pdfedit.1 Also, I suggest removing manfile generation from the makefiles (or at least remove it from default targets), as it no longer would be used and would cause trouble on systems without perl. Martin Petricek -- GPG/PGP Public key: http://www.petricek.net/petricm.pgp Fingerprint 6AA8 FFCE C061 1CB2 55F0 A1F3 3AA9 EB4F BD50 C1B8 /------------------------------------------------------------\ | WWW: http://www.petricek.net/ | \------------------------------------------------------------/ |
From: Michal H. <ms...@gm...> - 2008-05-22 10:01:53
Attachments:
release-prebuild_man.patch
check-perl.patch
|
On Wed, May 21, 2008 at 08:24:34PM +0200, Martin Petricek wrote: > Michal Hocko wrote: > > Hi, > > > > currently, man page is generated during normal make process (by > > doc/tools/docbook2man.pl script) which makes our make process dependant > > on perl. Moreover perl is not detected during configure which can > > silently lead to an empty man page in the end (if perl is not > > installed). > > > > I suggest attached patch which forces man page generation before > > distribution tarball is created. This solution is easier than perl > > detection and I find it better also from > > keep-as-few-dependency-as-possible POV. > > this patch alone won't solve the issue because: > > "make doc_man" in doc depends on Makefile.flags in root, generated by > configure, but configure is not run when creating the tarball. > > Command that would do the job would be: > > pdfedit-$VERSION/tools/docbook2man.pl pdfedit-$VERSION/doc/user/pdfedit.xml > >pdfedit-$VERSION/doc/user/pdfedit.1 You are right. Updated patch is attached. > > Also, I suggest removing manfile generation from the makefiles (or at least > remove it from default targets), as it no longer would be used and would > cause trouble on systems without perl. I wouldn't do so, because it could cause a problem for those who build directly from CVS. Instead, we could do something like check-perl.patch (attached). -- Michal Hocko |
From: Michal H. <ms...@gm...> - 2008-06-09 18:26:00
Attachments:
check-perl.patch
|
Martin has noted that dependency on /usr/bin/perl in check-perl.patch is not correct, because if we don't have perl installed the man file rule will fail, because there would be no rule for dependency. Sulution is to move check for binary in the rule. Updated patch is attached. -- Michal Hocko |
From: Martin P. <ma...@pe...> - 2008-06-10 03:23:41
|
It works fine now. Ack. Martin Petricek Michal Hocko wrote: > Martin has noted that dependency on /usr/bin/perl in check-perl.patch is > not correct, because if we don't have perl installed the man file rule > will fail, because there would be no rule for dependency. > > Sulution is to move check for binary in the rule. Updated patch is > attached. > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > > > ------------------------------------------------------------------------ > > _______________________________________________ > Pdfedit-devel mailing list > Pdf...@li... > https://lists.sourceforge.net/lists/listinfo/pdfedit-devel -- GPG/PGP Public key: http://www.petricek.net/petricm.pgp Fingerprint 6AA8 FFCE C061 1CB2 55F0 A1F3 3AA9 EB4F BD50 C1B8 /------------------------------------------------------------\ | WWW: http://www.petricek.net/ | \------------------------------------------------------------/ |