From: Ravikant D. <rav...@se...> - 2010-08-28 12:46:50
|
Hi I am getting exception whenever I am trying to save the pdf. Exception comes in the function template<PropertyType Tp> void simpleValueToString (const std::string& val, std::string& str) and in line { STATIC_CHECK ((pString == Tp) || (pName == Tp), COBJECT_INCORRECT_USE_OF_simpleObjToString_FUNCTION); switch (Tp) { case pString: { std::string validateStr = makeStringPdfValid (val); if (!isBinaryString(val)) as some times value of ‘val’ comes to be something like «bÑ*ÌÙ-RC[1]—#¡„ so isBinaryString() gives exception. Can u please look at this issue also…….. Regards, ☼Ravikant |
From: Michal H. <ms...@gm...> - 2010-08-30 10:54:21
|
On Sat, Aug 28, 2010 at 06:14:12PM +0530, Ravikant Dubey wrote: > Hi Hi, first of all, which version do you use? > > I am getting exception whenever I am trying to save the pdf. > > Exception comes in the function > > template<PropertyType Tp> > > void > > simpleValueToString (const std::string& val, std::string& str) > > and in line > > { > > STATIC_CHECK ((pString == Tp) || (pName == Tp), COBJECT_INCORRECT_USE_OF_simpleObjToString_FUNCTION); > > > switch (Tp) > { > case pString: > { > std::string validateStr = makeStringPdfValid (val); > if (!isBinaryString(val)) > > > > as some times value of ???val??? comes to be something like > > ????b??*????-RC[1]???#????? Probably some issues with email encoding? > > so isBinaryString() gives exception. I don't see any possible cause for an exception in this function, unless some invalid memory is provided. > > Can u please look at this issue also??????.. I assume that this happen with some specific document only (not in general). Could you post that document? Could you report this on our bug tracking system at: http://pdfedit.petricek.net/bt/main_page.php > > > > Regards, > > ???Ravikant Thanks -- Michal Hocko |
From: Ravikant D. <rav...@se...> - 2010-09-03 07:48:14
|
I am using MS-Visual Studio 2008 on windows XP Regards, ☼Ravikant -----Original Message----- From: Michal Hocko [mailto:ms...@gm...] Sent: Friday, September 03, 2010 12:15 PM To: Ravikant Dubey Cc: pdf...@li... Subject: Re: exception in simpleValueToString () On Fri, Sep 03, 2010 at 11:02:38AM +0530, Ravikant Dubey wrote: > Attached is the screenshot of assertion that is used to get Thanks. Could you send also the Visual studio version that you are using? Just for completness. Thanks! > > Regards, > ???Ravikant > -----Original Message----- > From: Michal Hocko [mailto:ms...@gm...] > Sent: Wednesday, September 01, 2010 11:17 PM > To: Ravikant Dubey > Cc: pdf...@li... > Subject: Re: exception in simpleValueToString () > > Attached you will find the updated patch which fixes all places where isCTYPE functions are used and the fixed original patch which lacked braces. > > On Tue, Aug 31, 2010 at 10:22:32AM +0200, Michal Hocko wrote: > > On Tue, Aug 31, 2010 at 10:36:01AM +0530, Ravikant Dubey wrote: > > > Hi Michal > > > Its working fine now.........Thanks for it... > > > > OK, thanks! Which system do you use, btw? What was the assert message? > > > > I would like to add that information to the patch description for > > further reference? > > Care to provide this, please? > > > > > And credits go, of course, to Jozo. I wouldn't think that some > > implementation could assert on that... Never seen that... > -- > Michal Hocko -- Michal Hocko |
From: Michal H. <ms...@gm...> - 2010-09-03 07:52:30
|
On Fri, Sep 03, 2010 at 01:15:33PM +0530, Ravikant Dubey wrote: > I am using MS-Visual Studio 2008 on windows XP Thanks! The patch is in the CVS. P.S. Please try to inline reply rather than top post because discussion is much cleaner in the end. > > Regards, > ???Ravikant > -----Original Message----- > From: Michal Hocko [mailto:ms...@gm...] > Sent: Friday, September 03, 2010 12:15 PM > To: Ravikant Dubey > Cc: pdf...@li... > Subject: Re: exception in simpleValueToString () > > On Fri, Sep 03, 2010 at 11:02:38AM +0530, Ravikant Dubey wrote: > > Attached is the screenshot of assertion that is used to get > > Thanks. Could you send also the Visual studio version that you are using? Just for completness. > > Thanks! > > > > > Regards, > > ???Ravikant > > -----Original Message----- > > From: Michal Hocko [mailto:ms...@gm...] > > Sent: Wednesday, September 01, 2010 11:17 PM > > To: Ravikant Dubey > > Cc: pdf...@li... > > Subject: Re: exception in simpleValueToString () > > > > Attached you will find the updated patch which fixes all places where isCTYPE functions are used and the fixed original patch which lacked braces. > > > > On Tue, Aug 31, 2010 at 10:22:32AM +0200, Michal Hocko wrote: > > > On Tue, Aug 31, 2010 at 10:36:01AM +0530, Ravikant Dubey wrote: > > > > Hi Michal > > > > Its working fine now.........Thanks for it... > > > > > > OK, thanks! Which system do you use, btw? What was the assert message? > > > > > > I would like to add that information to the patch description for > > > further reference? > > > > Care to provide this, please? > > > > > > > > And credits go, of course, to Jozo. I wouldn't think that some > > > implementation could assert on that... Never seen that... > > -- > > Michal Hocko > > > > -- > Michal Hocko -- Michal Hocko |
From: Ravikant D. <rav...@se...> - 2010-08-30 12:16:38
|
Hi exception is coming in function: bool isBinaryString(const std::string& val) { for(std::string::const_iterator i = val.begin(); i != val.end(); ++i) if(!isprint(*i)) return true; return false; } and in line: if(!isprint(*i)) whenever *i is coming negative like in case of «bÑ*ÌÙ-RC[1]—#¡„ Its true that this issue is pdf specific but it is coming in many files. Regards, ☼Ravikant -----Original Message----- From: Michal Hocko [mailto:ms...@gm...] Sent: Monday, August 30, 2010 4:24 PM To: Ravikant Dubey Cc: pdf...@li... Subject: Re: exception in simpleValueToString () On Sat, Aug 28, 2010 at 06:14:12PM +0530, Ravikant Dubey wrote: > Hi Hi, first of all, which version do you use? > > I am getting exception whenever I am trying to save the pdf. > > Exception comes in the function > > template<PropertyType Tp> > > void > > simpleValueToString (const std::string& val, std::string& str) > > and in line > > { > > STATIC_CHECK ((pString == Tp) || (pName == Tp), > COBJECT_INCORRECT_USE_OF_simpleObjToString_FUNCTION); > > > switch (Tp) > { > case pString: > { > std::string validateStr = makeStringPdfValid (val); > if (!isBinaryString(val)) > > > > as some times value of ???val??? comes to be something like > > ????b??*????-RC[1]???#????? Probably some issues with email encoding? > > so isBinaryString() gives exception. I don't see any possible cause for an exception in this function, unless some invalid memory is provided. > > Can u please look at this issue also??????.. I assume that this happen with some specific document only (not in general). Could you post that document? Could you report this on our bug tracking system at: http://pdfedit.petricek.net/bt/main_page.php > > > > Regards, > > ???Ravikant Thanks -- Michal Hocko |
From: Jozef M. <mis...@ho...> - 2010-08-30 12:28:08
|
Dne Mon, 30 Aug 2010 14:13:56 +0200 Ravikant Dubey <rav...@se...> napsal(a): > Hi > exception is coming in function: > bool isBinaryString(const std::string& val) > { > for(std::string::const_iterator i = val.begin(); i != val.end(); ++i) > if(!isprint(*i)) i guess you are using debug version and the exception an assert. if so than simple fix is to cast i to unsigned char. michal, can you fix it if Ravikant confirms. I can not access cvs now. jozef > return true; > return false; > } > and in line: > if(!isprint(*i)) > whenever *i is coming negative like in case of > «bÑ*ÌÙ-RC[1]—#¡„ > > Its true that this issue is pdf specific but it is coming in many files. > > Regards, > ☼Ravikant > -----Original Message----- > From: Michal Hocko [mailto:ms...@gm...] > Sent: Monday, August 30, 2010 4:24 PM > To: Ravikant Dubey > Cc: pdf...@li... > Subject: Re: exception in simpleValueToString () > > On Sat, Aug 28, 2010 at 06:14:12PM +0530, Ravikant Dubey wrote: >> Hi > > Hi, > first of all, which version do you use? > >> >> I am getting exception whenever I am trying to save the pdf. >> >> Exception comes in the function >> >> template<PropertyType Tp> >> >> void >> >> simpleValueToString (const std::string& val, std::string& str) >> >> and in line >> >> { >> >> STATIC_CHECK ((pString == Tp) || (pName == Tp), >> COBJECT_INCORRECT_USE_OF_simpleObjToString_FUNCTION); >> >> >> switch (Tp) >> { >> case pString: >> { >> std::string validateStr = makeStringPdfValid (val); >> if (!isBinaryString(val)) >> >> >> >> as some times value of ???val??? comes to be something like >> >> ????b??*????-RC[1]???#????? > > Probably some issues with email encoding? > >> >> so isBinaryString() gives exception. > > I don't see any possible cause for an exception in this function, unless > some invalid memory is provided. > >> >> Can u please look at this issue also??????.. > > I assume that this happen with some specific document only (not in > general). Could you post that document? Could you report this on our bug > tracking system at: http://pdfedit.petricek.net/bt/main_page.php > >> >> >> >> Regards, >> >> ???Ravikant > > Thanks > -- > Michal Hocko > > > ------------------------------------------------------------------------------ > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue > and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > _______________________________________________ > Pdfedit-devel mailing list > Pdf...@li... > https://lists.sourceforge.net/lists/listinfo/pdfedit-devel -- Tato zpráva byla vytvořena převratným poštovním klientem Opery: http://www.opera.com/mail/ |
From: Michal H. <ms...@gm...> - 2010-08-30 12:36:05
|
On Mon, Aug 30, 2010 at 05:43:56PM +0530, Ravikant Dubey wrote: > Hi > exception is coming in function: > bool isBinaryString(const std::string& val) > { > for(std::string::const_iterator i = val.begin(); i != val.end(); ++i) > if(!isprint(*i)) > return true; > return false; > } > and in line: > if(!isprint(*i)) > whenever *i is coming negative like in case of This sounds fishy. *i should always return valid data (if something doesn't modify the string in parallel which is not done in PDFedit). > ????b??*????-RC[1]???#????? > > Its true that this issue is pdf specific but it is coming in many files. I have never seen something like that Can I get such a document? > > Regards, > ???Ravikant > -----Original Message----- > From: Michal Hocko [mailto:ms...@gm...] > Sent: Monday, August 30, 2010 4:24 PM > To: Ravikant Dubey > Cc: pdf...@li... > Subject: Re: exception in simpleValueToString () > > On Sat, Aug 28, 2010 at 06:14:12PM +0530, Ravikant Dubey wrote: > > Hi > > Hi, > first of all, which version do you use? > > > > > I am getting exception whenever I am trying to save the pdf. > > > > Exception comes in the function > > > > template<PropertyType Tp> > > > > void > > > > simpleValueToString (const std::string& val, std::string& str) > > > > and in line > > > > { > > > > STATIC_CHECK ((pString == Tp) || (pName == Tp), > > COBJECT_INCORRECT_USE_OF_simpleObjToString_FUNCTION); > > > > > > switch (Tp) > > { > > case pString: > > { > > std::string validateStr = makeStringPdfValid (val); > > if (!isBinaryString(val)) > > > > > > > > as some times value of ???val??? comes to be something like > > > > ????b??*????-RC[1]???#????? > > Probably some issues with email encoding? > > > > > so isBinaryString() gives exception. > > I don't see any possible cause for an exception in this function, unless some invalid memory is provided. > > > > > Can u please look at this issue also??????.. > > I assume that this happen with some specific document only (not in general). Could you post that document? Could you report this on our bug tracking system at: http://pdfedit.petricek.net/bt/main_page.php > > > > > > > > > Regards, > > > > ???Ravikant > > Thanks > -- > Michal Hocko -- Michal Hocko |
From: Ravikant D. <rav...@se...> - 2010-08-30 12:58:46
Attachments:
Copy of Test.pdf
|
Hi PFA Sorry due to encoding the string is not coming properly. Whenever I am trying to save anything on this pdf I am getting exception. Regards, ☼Ravikant -----Original Message----- From: Michal Hocko [mailto:ms...@gm...] Sent: Monday, August 30, 2010 6:06 PM To: Ravikant Dubey Cc: pdf...@li... Subject: Re: exception in simpleValueToString () On Mon, Aug 30, 2010 at 05:43:56PM +0530, Ravikant Dubey wrote: > Hi > exception is coming in function: > bool isBinaryString(const std::string& val) { > for(std::string::const_iterator i = val.begin(); i != val.end(); ++i) > if(!isprint(*i)) > return true; > return false; > } > and in line: > if(!isprint(*i)) > whenever *i is coming negative like in case of This sounds fishy. *i should always return valid data (if something doesn't modify the string in parallel which is not done in PDFedit). > ????b??*????-RC[1]???#????? > > Its true that this issue is pdf specific but it is coming in many files. I have never seen something like that Can I get such a document? > > Regards, > ???Ravikant > -----Original Message----- > From: Michal Hocko [mailto:ms...@gm...] > Sent: Monday, August 30, 2010 4:24 PM > To: Ravikant Dubey > Cc: pdf...@li... > Subject: Re: exception in simpleValueToString () > > On Sat, Aug 28, 2010 at 06:14:12PM +0530, Ravikant Dubey wrote: > > Hi > > Hi, > first of all, which version do you use? > > > > > I am getting exception whenever I am trying to save the pdf. > > > > Exception comes in the function > > > > template<PropertyType Tp> > > > > void > > > > simpleValueToString (const std::string& val, std::string& str) > > > > and in line > > > > { > > > > STATIC_CHECK ((pString == Tp) || (pName == Tp), > > COBJECT_INCORRECT_USE_OF_simpleObjToString_FUNCTION); > > > > > > switch (Tp) > > { > > case pString: > > { > > std::string validateStr = makeStringPdfValid (val); > > if (!isBinaryString(val)) > > > > > > > > as some times value of ???val??? comes to be something like > > > > ????b??*????-RC[1]???#????? > > Probably some issues with email encoding? > > > > > so isBinaryString() gives exception. > > I don't see any possible cause for an exception in this function, unless some invalid memory is provided. > > > > > Can u please look at this issue also??????.. > > I assume that this happen with some specific document only (not in > general). Could you post that document? Could you report this on our > bug tracking system at: http://pdfedit.petricek.net/bt/main_page.php > > > > > > > > > Regards, > > > > ???Ravikant > > Thanks > -- > Michal Hocko -- Michal Hocko |
From: Michal H. <ms...@gm...> - 2010-08-30 12:52:49
Attachments:
isBinary_const_type_fix.patch
|
On Mon, Aug 30, 2010 at 02:27:08PM +0200, Jozef Misutka wrote: > Dne Mon, 30 Aug 2010 14:13:56 +0200 Ravikant Dubey > <rav...@se...> napsal(a): > > >Hi > >exception is coming in function: > >bool isBinaryString(const std::string& val) > >{ > > for(std::string::const_iterator i = val.begin(); i != val.end(); ++i) > > if(!isprint(*i)) > > i guess you are using debug version and the exception an assert. if > so than simple fix is to cast i to unsigned char. What exception you have in mind? Type check in isprint? The glibc code is rather cryptic to read... > > michal, can you fix it if Ravikant confirms. I can not access cvs now. Anyway, I do agree that this is reasonable in anycase. The patch is attached. Ravikant, could you test it, please? -- Michal Hocko |
From: Ravikant D. <rav...@se...> - 2010-08-31 05:20:12
|
Hi Michal Its working fine now.........Thanks for it... Regards, ☼Ravikant -----Original Message----- From: Michal Hocko [mailto:ms...@gm...] Sent: Monday, August 30, 2010 6:23 PM To: Ravikant Dubey Cc: pdf...@li...; Jozef Misutka Subject: Re: exception in simpleValueToString () On Mon, Aug 30, 2010 at 02:27:08PM +0200, Jozef Misutka wrote: > Dne Mon, 30 Aug 2010 14:13:56 +0200 Ravikant Dubey > <rav...@se...> napsal(a): > > >Hi > >exception is coming in function: > >bool isBinaryString(const std::string& val) { > > for(std::string::const_iterator i = val.begin(); i != val.end(); ++i) > > if(!isprint(*i)) > > i guess you are using debug version and the exception an assert. if so > than simple fix is to cast i to unsigned char. What exception you have in mind? Type check in isprint? The glibc code is rather cryptic to read... > > michal, can you fix it if Ravikant confirms. I can not access cvs now. Anyway, I do agree that this is reasonable in anycase. The patch is attached. Ravikant, could you test it, please? -- Michal Hocko |
From: Michal H. <ms...@gm...> - 2010-08-31 08:22:41
|
On Tue, Aug 31, 2010 at 10:36:01AM +0530, Ravikant Dubey wrote: > Hi Michal > Its working fine now.........Thanks for it... OK, thanks! Which system do you use, btw? What was the assert message? I would like to add that information to the patch description for further reference? And credits go, of course, to Jozo. I wouldn't think that some implementation could assert on that... Never seen that... > > Regards, > ???Ravikant > -----Original Message----- > From: Michal Hocko [mailto:ms...@gm...] > Sent: Monday, August 30, 2010 6:23 PM > To: Ravikant Dubey > Cc: pdf...@li...; Jozef Misutka > Subject: Re: exception in simpleValueToString () > > On Mon, Aug 30, 2010 at 02:27:08PM +0200, Jozef Misutka wrote: > > Dne Mon, 30 Aug 2010 14:13:56 +0200 Ravikant Dubey > > <rav...@se...> napsal(a): > > > > >Hi > > >exception is coming in function: > > >bool isBinaryString(const std::string& val) { > > > for(std::string::const_iterator i = val.begin(); i != val.end(); ++i) > > > if(!isprint(*i)) > > > > i guess you are using debug version and the exception an assert. if so > > than simple fix is to cast i to unsigned char. > > What exception you have in mind? Type check in isprint? The glibc code is rather cryptic to read... > > > > > michal, can you fix it if Ravikant confirms. I can not access cvs now. > > Anyway, I do agree that this is reasonable in anycase. The patch is attached. > Ravikant, could you test it, please? > > -- > Michal Hocko -- Michal Hocko |
From: Ravikant D. <rav...@se...> - 2010-09-03 05:35:19
Attachments:
assertion.JPG
|
Attached is the screenshot of assertion that is used to get Regards, ☼Ravikant -----Original Message----- From: Michal Hocko [mailto:ms...@gm...] Sent: Wednesday, September 01, 2010 11:17 PM To: Ravikant Dubey Cc: pdf...@li... Subject: Re: exception in simpleValueToString () Attached you will find the updated patch which fixes all places where isCTYPE functions are used and the fixed original patch which lacked braces. On Tue, Aug 31, 2010 at 10:22:32AM +0200, Michal Hocko wrote: > On Tue, Aug 31, 2010 at 10:36:01AM +0530, Ravikant Dubey wrote: > > Hi Michal > > Its working fine now.........Thanks for it... > > OK, thanks! Which system do you use, btw? What was the assert message? > > I would like to add that information to the patch description for > further reference? Care to provide this, please? > > And credits go, of course, to Jozo. I wouldn't think that some > implementation could assert on that... Never seen that... -- Michal Hocko |
From: Michal H. <ms...@gm...> - 2010-09-03 06:45:20
|
On Fri, Sep 03, 2010 at 11:02:38AM +0530, Ravikant Dubey wrote: > Attached is the screenshot of assertion that is used to get Thanks. Could you send also the Visual studio version that you are using? Just for completness. Thanks! > > Regards, > ???Ravikant > -----Original Message----- > From: Michal Hocko [mailto:ms...@gm...] > Sent: Wednesday, September 01, 2010 11:17 PM > To: Ravikant Dubey > Cc: pdf...@li... > Subject: Re: exception in simpleValueToString () > > Attached you will find the updated patch which fixes all places where isCTYPE functions are used and the fixed original patch which lacked braces. > > On Tue, Aug 31, 2010 at 10:22:32AM +0200, Michal Hocko wrote: > > On Tue, Aug 31, 2010 at 10:36:01AM +0530, Ravikant Dubey wrote: > > > Hi Michal > > > Its working fine now.........Thanks for it... > > > > OK, thanks! Which system do you use, btw? What was the assert message? > > > > I would like to add that information to the patch description for > > further reference? > > Care to provide this, please? > > > > > And credits go, of course, to Jozo. I wouldn't think that some > > implementation could assert on that... Never seen that... > -- > Michal Hocko -- Michal Hocko |