From: Michal H. <ms...@gm...> - 2008-01-17 13:46:51
Attachments:
confparser_include.patch
|
Varun Hiremath has reported some problems with gcc 4.3 compilation. At least src/utils/confparser.h fails to compile because string header is not present. Attached patch solves the situation, but maybe we don't need to include whole cstring header and use only some subset (some included header) of it. -- Michal Hocko |
From: Michal H. <ms...@gm...> - 2008-01-27 14:14:14
|
On Thu, Jan 17, 2008 at 02:46:42PM +0100, Michal Hocko wrote: > Varun Hiremath has reported some problems with gcc 4.3 compilation. > At least src/utils/confparser.h fails to compile because string header > is not present. > Attached patch solves the situation, but maybe we don't need to include > whole cstring header and use only some subset (some included header) > of it. I have checked it with gcc 4.3.0 and no problem occured. Even more: /usr/include/c++/4.3 $ find -name string ./string ./debug/string My scenario was (with the current devel-msts-unified_makefiles branch): ./configure CC=gcc-4.3 CXX=g++-4.3 make Varun, could you provide more information how to reproduce? > Compilation with gcc 4.3. fails because string header is not present. > Using cstring instead fixes this problem. > See http://gcc.gnu.org/gcc-4.3/porting_to.html for more information > > Index: src/utils/confparser.h > =================================================================== > RCS file: /cvsroot/pdfedit/pdfedit/src/utils/confparser.h,v > retrieving revision 1.11 > diff -u -r1.11 confparser.h > --- src/utils/confparser.h 7 Oct 2007 20:38:42 -0000 1.11 > +++ src/utils/confparser.h 17 Jan 2008 13:34:06 -0000 > @@ -12,7 +12,7 @@ > #define _CONFPARSER_H_ > > #include<iostream> > -#include<string> > +#include<cstring> > #include<vector> > > namespace configuration > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Pdfedit-devel mailing list > Pdf...@li... > https://lists.sourceforge.net/lists/listinfo/pdfedit-devel -- Michal Hocko |
From: Varun H. <var...@ii...> - 2008-01-28 17:08:26
|
Hi, On Mon, 28 Jan, 2008 at 05:14:24PM +0100, Michal Hocko wrote: > No, we are including it from confparser.cc, but this won't make any > difference here. > > > to build but now I have included kernel/static.h and it builds. > > Could you try the latest CVS (from devel-msts-unified_makefiles branch)? > Do you still have problem to get sources from there? > I have just tried: > cvs -z3 -d:pserver:ano...@pd...:/cvsroot/pdfedit \ > co -r devel-msts-unified_makefiles pdfedit Okay, I checked out the latest sources and tried autoconf + configure but it gave some error saying install-sh script not present. So, I copied /usr/share/automake-1.9/install-sh to pdfedit directory, then did configure + make and it compiled without any problems. So kernel/static.h was missing when I checked out last time. > > and didn't have any problems. > > > > > But, actually you are indirectly including cstring through the boost > > header files. In kernel/static.h you have: > > > > //============================================ > > // boost > > //============================================ > > #include <boost/smart_ptr.hpp> > > #include <boost/iostreams/stream.hpp> > > #include <boost/iostreams/filtering_stream.hpp> > > > > > > If you look at boost/iostreams/stream.hpp it has: > > > > #include <boost/iostreams/constants.hpp> > > #include <boost/iostreams/detail/char_traits.hpp> > > > > and now if you look at boost/iostreams/detail/char_traits.hpp: > > > > # include <boost/config.hpp> // Make sure size_t is in std. > > # include <cstddef> > > # include <cstring> <<=========== > > # include <cstdio> > > Yes, but note that these are included only if > BOOST_IOSTREAMS_NO_STREAM_TEMPLATES is defined. I don't have any idea > what is it... > Nevertheless it is not clean to rely on including this header by > boost headers, so it has to be sorted out. > > > So, you can as well include cstring directly because the #include > > <string> is never used from kernel/static.h (you may remove it). It is > > this cstring which is included through boost headers that makes it > > work with gcc/g++ 4.3 > > Jozo, could you check if it is clear to add #include <cstring> into > kernel/static.h instead of string? > My quick test (cd src && make clean & make) was succesfull. > > > > > Hope that ends all confusion. > > Thanks for your investigation. > > Just to be sure. Could you send me string from 4.3 and some older c++ > directory? I still don't understand difference between those 2 files. > All C++ manuals/books claims that #include <string> should be used when > C++ strings are used. Please find attached cstring and string files. I was also under the same impression that we should use string for all string functions (that is what I read in school :-)) until recently when I was told that now we are supposed to use cstring. I think it is the same string.h file rewritten to comply with new c++ standards. BTW, if you use string.h instead of string it works I guess (I tried it before) Thanks Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Varun H. <var...@ii...> - 2008-01-28 17:15:26
Attachments:
string.h
|
On Mon, 28 Jan, 2008 at 10:54:27PM +0530, Varun Hiremath wrote: > > Just to be sure. Could you send me string from 4.3 and some older c++ > > directory? I still don't understand difference between those 2 files. > > All C++ manuals/books claims that #include <string> should be used when > > C++ strings are used. > > Please find attached cstring and string files. > > I was also under the same impression that we should use string for all > string functions (that is what I read in school :-)) until recently > when I was told that now we are supposed to use cstring. I think it is > the same string.h file rewritten to comply with new c++ standards. > > BTW, if you use string.h instead of string it works I guess (I tried > it before) Yes, I was right. The string.h file that you were talking (which we used earlier) is actaully in /usr/include/string.h (attached). So, if we want to use this old file we need to use #include <string.h> or else we should use the new cstring file #include<cstring> But, don't use #include <string> from now on. Thanks Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Jozef M. <mis...@ho...> - 2008-01-28 17:52:18
|
now we are mixing two things together (c++ string class and c/c++ raw strin= g operations). 1) <string> should be always used when you want to use c++ s= td::string class2) <string.h> is a c style header for raw string operations= 3) <cstring> is a c++ header for raw string operationsjozo > Date: Mon, 28 Jan 2008 23:01:29 +0530> From: var...@ii...> To= : ms...@gm...> Subject: Re: [Pdfedit-devel] confparser gcc 4.3 compil= ation problem> CC: pdf...@li...> > On Mon, 28 Jan, 2= 008 at 10:54:27PM +0530, Varun Hiremath wrote:> > > Just to be sure. Could = you send me string from 4.3 and some older c++> > > directory? I still don'= t understand difference between those 2 files.> > > All C++ manuals/books c= laims that #include <string> should be used when> > > C++ strings are used.= > > > > Please find attached cstring and string files. > > > > I was also u= nder the same impression that we should use string for all> > string functi= ons (that is what I read in school :-)) until recently> > when I was told t= hat now we are supposed to use cstring. I think it is> > the same string.h = file rewritten to comply with new c++ standards.> > > > BTW, if you use str= ing.h instead of string it works I guess (I tried> > it before)> > Yes, I w= as right. The string.h file that you were talking (which we> used earlier) = is actaully in /usr/include/string.h (attached). So, if> we want to use thi= s old file we need to use > #include <string.h>> > or else we should use th= e new cstring file> #include<cstring>> > But, don't use #include <string> f= rom now on.> > Thanks> Varun> > -- > Varun Hiremath> Undergraduate Student,= > Aerospace Engineering Department,> Indian Institute of Technology Madras,= > Chennai, India> -------------------------------------> Homepage: http://v= arun.travisbsd.org Connect and share in new ways with Windows Live. Get it now!=20 _________________________________________________________________ Climb to the top of the charts!=A0Play the word scramble challenge with sta= r power. http://club.live.com/star_shuffle.aspx?icid=3Dstarshuffle_wlmailtextlink_ja= n= |
From: Varun H. <var...@ii...> - 2008-01-28 07:10:06
|
Hi Michal, On Sun, 27 Jan, 2008 at 03:14:29PM +0100, Michal Hocko wrote: > On Thu, Jan 17, 2008 at 02:46:42PM +0100, Michal Hocko wrote: > > Varun Hiremath has reported some problems with gcc 4.3 compilation. > > At least src/utils/confparser.h fails to compile because string header > > is not present. > > Attached patch solves the situation, but maybe we don't need to include > > whole cstring header and use only some subset (some included header) > > of it. > > I have checked it with gcc 4.3.0 and no problem occured. > Even more: > /usr/include/c++/4.3 $ find -name string > ./string > ./debug/string > > My scenario was (with the current devel-msts-unified_makefiles branch): > ./configure CC=gcc-4.3 CXX=g++-4.3 > make > > Varun, could you provide more information how to reproduce? I tried again same ./configure CC=gcc-4.3 CXX=g++-4.3 make and it fails with this error: ------------------------------------------------------------------------- g++-4.3 -c -O2 -W -Wall -Wconversion -Wwrite-strings -Wno-unused-variable -Wunused-function -Wwrite-strings -Wunused-macros -fmessage-length=0 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -fexceptions -pipe -I. -I/home/god/bollin/build-area/pdfedit-0.4/src -I/home/god/bollin/build-area/pdfedit-0.4/src/xpdf/ -I/usr/include -I/usr/include/freetype2 -o confparser.o confparser.cc In file included from confparser.cc:11: /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h: In member function 'virtual bool configuration::StringConfigurationParser::parse(std::string&, std::string&)': /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h:259: error: 'memset' was not declared in this scope /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h:283: error: 'strpbrk' was not declared in this scope /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h:287: error: 'strlen' was not declared in this scope /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h:297: error: 'strpbrk' was not declared in this scope make[2]: *** [confparser.o] Error 1 make[2]: Leaving directory `/home/god/bollin/build-area/pdfedit-0.4/src/utils' make[1]: *** [utils] Error 2 make[1]: Leaving directory `/home/god/bollin/build-area/pdfedit-0.4/src' make: *** [source] Error 2 ------------------------------------------------------------------------- I have installed the latest gcc-4.3 package from sid. Are you sure you haven't already replaced string with cstring? Regards Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Michal H. <ms...@gm...> - 2008-01-29 09:18:01
|
On Mon, Jan 28, 2008 at 10:54:27PM +0530, Varun Hiremath wrote: > Hi, > > On Mon, 28 Jan, 2008 at 05:14:24PM +0100, Michal Hocko wrote: > > No, we are including it from confparser.cc, but this won't make any > > difference here. > > > > > to build but now I have included kernel/static.h and it builds. > > > > Could you try the latest CVS (from devel-msts-unified_makefiles branch)? > > Do you still have problem to get sources from there? > > I have just tried: > > cvs -z3 -d:pserver:ano...@pd...:/cvsroot/pdfedit \ > > co -r devel-msts-unified_makefiles pdfedit > > Okay, I checked out the latest sources and tried autoconf + configure > but it gave some error saying install-sh script not present. > > So, I copied /usr/share/automake-1.9/install-sh to pdfedit directory, > then did configure + make and it compiled without any problems. Could you sent config.{log,status} and autoconf --version? [...] -- Michal Hocko |
From: Michal H. <ms...@gm...> - 2008-01-28 08:53:31
|
On Mon, Jan 28, 2008 at 12:56:01PM +0530, Varun Hiremath wrote: > Hi Michal, > > On Sun, 27 Jan, 2008 at 03:14:29PM +0100, Michal Hocko wrote: > > On Thu, Jan 17, 2008 at 02:46:42PM +0100, Michal Hocko wrote: > > > Varun Hiremath has reported some problems with gcc 4.3 compilation. > > > At least src/utils/confparser.h fails to compile because string header > > > is not present. > > > Attached patch solves the situation, but maybe we don't need to include > > > whole cstring header and use only some subset (some included header) > > > of it. > > > > I have checked it with gcc 4.3.0 and no problem occured. > > Even more: > > /usr/include/c++/4.3 $ find -name string > > ./string > > ./debug/string > > > > My scenario was (with the current devel-msts-unified_makefiles branch): > > ./configure CC=gcc-4.3 CXX=g++-4.3 > > make > > > > Varun, could you provide more information how to reproduce? > > I tried again same > ./configure CC=gcc-4.3 CXX=g++-4.3 > make > > and it fails with this error: > > ------------------------------------------------------------------------- > g++-4.3 -c -O2 -W -Wall -Wconversion -Wwrite-strings > -Wno-unused-variable -Wunused-function -Wwrite-strings -Wunused-macros > -fmessage-length=0 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing > -fexceptions -pipe > -I. -I/home/god/bollin/build-area/pdfedit-0.4/src > -I/home/god/bollin/build-area/pdfedit-0.4/src/xpdf/ -I/usr/include > -I/usr/include/freetype2 -o confparser.o confparser.cc > In file included from confparser.cc:11: > /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h: In > member function 'virtual bool > configuration::StringConfigurationParser::parse(std::string&, > std::string&)': > /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h:259: > error: 'memset' was not declared in this scope > /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h:283: > error: 'strpbrk' was not declared in this scope > /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h:287: > error: 'strlen' was not declared in this scope > /home/god/bollin/build-area/pdfedit-0.4/src/utils/confparser.h:297: > error: 'strpbrk' was not declared in this scope > make[2]: *** [confparser.o] Error 1 > make[2]: Leaving directory > `/home/god/bollin/build-area/pdfedit-0.4/src/utils' > make[1]: *** [utils] Error 2 > make[1]: Leaving directory > `/home/god/bollin/build-area/pdfedit-0.4/src' > make: *** [source] Error 2 > ------------------------------------------------------------------------- > > I have installed the latest gcc-4.3 package from sid. I have installed the one from testing: $ gcc-4.3 -v Using built-in specs. Target: i486-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Debian 4.3-20080116-1' --with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.3 --program-suffix=-4.3 --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-targets=all --enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu --target=i486-linux-gnu Thread model: posix gcc version 4.3.0 20080116 (experimental) [trunk revision 131577] (Debian 4.3-20080116-1) > > Are you sure you haven't already replaced string with cstring? Yes: ...src/utils $ grep "#include" confparser.{cc,h} confparser.cc:#include "kernel/static.h" confparser.cc:#include "utils/confparser.h" confparser.h:#include<iostream> confparser.h:#include<string> confparser.h:#include<vector> My output: ...src/utils $ g++-4.3 -c -g -DDEBUG -O0 -W -Wall -Wconversion -Wwrite-strings -Wno-unused-variable -Wunused-function -Wwrite-strings -Wunused-macros -fmessage-length=0 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -fexceptions -pipe -I. -I/home/miso/devel/pdfedit-unified_makefiles/src -I/home/miso/devel/pdfedit-unified_makefiles/src/xpdf/ -I/usr/include -I/usr/include/freetype2 -o confparser.o confparser.cc In file included from /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/xpdf/SplashOutputDev.h:19, from /home/miso/devel/pdfedit-unified_makefiles/src/kernel/xpdf.h:27, from /home/miso/devel/pdfedit-unified_makefiles/src/kernel/static.h:64, from confparser.cc:11: /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/splash/SplashTypes.h: In function 'void splashColorXor(Guchar*, Guchar*)': /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/splash/SplashTypes.h:92: warning: conversion to 'unsigned char' from 'int' may alter its value /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/splash/SplashTypes.h:93: warning: conversion to 'unsigned char' from 'int' may alter its value /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/splash/SplashTypes.h:94: warning: conversion to 'unsigned char' from 'int' may alter its value > > Regards > Varun > > -- > Varun Hiremath > Undergraduate Student, > Aerospace Engineering Department, > Indian Institute of Technology Madras, > Chennai, India > ------------------------------------- > Homepage: http://varun.travisbsd.org -- Michal Hocko |
From: Varun H. <var...@ii...> - 2008-01-28 18:00:38
|
Hi Jozef, On Mon, 28 Jan, 2008 at 05:50:57PM +0000, Jozef Misutka wrote: > now we are mixing two things together (c++ string class and c/c++ raw string operations). > > 1) <string> should be always used when you want to use c++ std::string class > 2) <string.h> is a c style header for raw string operations > 3) <cstring> is a c++ header for raw string operations > jozo Right, that summarises it nicely. Thanks a lot for the info. Regards Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Varun H. <var...@ii...> - 2008-01-29 14:49:21
Attachments:
config.status
config.log
|
On Tue, 29 Jan, 2008 at 10:17:55AM +0100, Michal Hocko wrote: > On Mon, Jan 28, 2008 at 10:54:27PM +0530, Varun Hiremath wrote: > > Hi, > > > > On Mon, 28 Jan, 2008 at 05:14:24PM +0100, Michal Hocko wrote: > > > No, we are including it from confparser.cc, but this won't make any > > > difference here. > > > > > > > to build but now I have included kernel/static.h and it builds. > > > > > > Could you try the latest CVS (from devel-msts-unified_makefiles branch)? > > > Do you still have problem to get sources from there? > > > I have just tried: > > > cvs -z3 -d:pserver:ano...@pd...:/cvsroot/pdfedit \ > > > co -r devel-msts-unified_makefiles pdfedit > > > > Okay, I checked out the latest sources and tried autoconf + configure > > but it gave some error saying install-sh script not present. > > > > So, I copied /usr/share/automake-1.9/install-sh to pdfedit directory, > > then did configure + make and it compiled without any problems. > > Could you sent config.{log,status} and autoconf --version? $ autoconf --version autoconf (GNU Autoconf) 2.61 config.{log,status} attached. Regards Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Michal H. <ms...@gm...> - 2008-02-07 11:25:39
Attachments:
install-sh-problem_fix.patch
|
On Tue, Jan 29, 2008 at 08:35:23PM +0530, Varun Hiremath wrote: > On Tue, 29 Jan, 2008 at 10:17:55AM +0100, Michal Hocko wrote: > > On Mon, Jan 28, 2008 at 10:54:27PM +0530, Varun Hiremath wrote: > > > Hi, > > > > > > On Mon, 28 Jan, 2008 at 05:14:24PM +0100, Michal Hocko wrote: > > > > No, we are including it from confparser.cc, but this won't make any > > > > difference here. > > > > > > > > > to build but now I have included kernel/static.h and it builds. > > > > > > > > Could you try the latest CVS (from devel-msts-unified_makefiles branch)? > > > > Do you still have problem to get sources from there? > > > > I have just tried: > > > > cvs -z3 -d:pserver:ano...@pd...:/cvsroot/pdfedit \ > > > > co -r devel-msts-unified_makefiles pdfedit > > > > > > Okay, I checked out the latest sources and tried autoconf + configure > > > but it gave some error saying install-sh script not present. > > > > > > So, I copied /usr/share/automake-1.9/install-sh to pdfedit directory, > > > then did configure + make and it compiled without any problems. > > > > Could you sent config.{log,status} and autoconf --version? > > $ autoconf --version > autoconf (GNU Autoconf) 2.61 > > config.{log,status} attached. Sorry, for late response, but I am on bussines trip (until friday). See attached patch, which should fix the problem. > > Regards > Varun > > -- > Varun Hiremath > Undergraduate Student, > Aerospace Engineering Department, > Indian Institute of Technology Madras, > Chennai, India > ------------------------------------- > Homepage: http://varun.travisbsd.org -- Michal Hocko |
From: Varun H. <var...@ii...> - 2008-01-28 09:28:06
|
Hi Michal, On Mon, 28 Jan, 2008 at 09:53:25AM +0100, Michal Hocko wrote: > > I have installed the latest gcc-4.3 package from sid. > > I have installed the one from testing: > $ gcc-4.3 -v > Using built-in specs. > Target: i486-linux-gnu > Configured with: ../src/configure -v --with-pkgversion='Debian 4.3-20080116-1' --with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.3 --program-suffix=-4.3 --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-targets=all --enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu --target=i486-linux-gnu > Thread model: posix > gcc version 4.3.0 20080116 (experimental) [trunk revision 131577] (Debian 4.3-20080116-1) Okay, I have the same version. > > > > > Are you sure you haven't already replaced string with cstring? > > Yes: > ...src/utils $ grep "#include" confparser.{cc,h} > confparser.cc:#include "kernel/static.h" > confparser.cc:#include "utils/confparser.h" > confparser.h:#include<iostream> > confparser.h:#include<string> > confparser.h:#include<vector> > > > My output: > ...src/utils $ g++-4.3 -c -g -DDEBUG -O0 -W -Wall -Wconversion -Wwrite-strings -Wno-unused-variable -Wunused-function -Wwrite-strings -Wunused-macros -fmessage-length=0 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -fexceptions -pipe -I. -I/home/miso/devel/pdfedit-unified_makefiles/src -I/home/miso/devel/pdfedit-unified_makefiles/src/xpdf/ -I/usr/include -I/usr/include/freetype2 -o confparser.o confparser.cc > In file included from /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/xpdf/SplashOutputDev.h:19, > from /home/miso/devel/pdfedit-unified_makefiles/src/kernel/xpdf.h:27, > from /home/miso/devel/pdfedit-unified_makefiles/src/kernel/static.h:64, > from confparser.cc:11: > /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/splash/SplashTypes.h: In function 'void splashColorXor(Guchar*, Guchar*)': > /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/splash/SplashTypes.h:92: warning: conversion to 'unsigned char' from 'int' may alter its value > /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/splash/SplashTypes.h:93: warning: conversion to 'unsigned char' from 'int' may alter its value > /home/miso/devel/pdfedit-unified_makefiles/src/xpdf/splash/SplashTypes.h:94: warning: conversion to 'unsigned char' from 'int' may alter its value Well, this is strange because I tried again on a remote machine (amd64) with Debian testing installed and it failed with the same error. Could you also please try on some other machine? Regards Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Michal H. <ms...@gm...> - 2008-01-29 15:03:49
|
On Tue, Jan 29, 2008 at 08:35:23PM +0530, Varun Hiremath wrote: > On Tue, 29 Jan, 2008 at 10:17:55AM +0100, Michal Hocko wrote: > > On Mon, Jan 28, 2008 at 10:54:27PM +0530, Varun Hiremath wrote: > > > Hi, > > > > > > On Mon, 28 Jan, 2008 at 05:14:24PM +0100, Michal Hocko wrote: > > > > No, we are including it from confparser.cc, but this won't make any > > > > difference here. > > > > > > > > > to build but now I have included kernel/static.h and it builds. > > > > > > > > Could you try the latest CVS (from devel-msts-unified_makefiles branch)? > > > > Do you still have problem to get sources from there? > > > > I have just tried: > > > > cvs -z3 -d:pserver:ano...@pd...:/cvsroot/pdfedit \ > > > > co -r devel-msts-unified_makefiles pdfedit > > > > > > Okay, I checked out the latest sources and tried autoconf + configure > > > but it gave some error saying install-sh script not present. > > > > > > So, I copied /usr/share/automake-1.9/install-sh to pdfedit directory, > > > then did configure + make and it compiled without any problems. > > > > Could you sent config.{log,status} and autoconf --version? > > $ autoconf --version > autoconf (GNU Autoconf) 2.61 > > config.{log,status} attached. These are from successfull run of autobuild after you have copied install-sh into source root? Is there some ouput without install-sh? > > Regards > Varun > > -- > Varun Hiremath > Undergraduate Student, > Aerospace Engineering Department, > Indian Institute of Technology Madras, > Chennai, India > ------------------------------------- > Homepage: http://varun.travisbsd.org -- Michal Hocko |
From: Varun H. <var...@ii...> - 2008-01-29 17:17:01
|
On Tue, 29 Jan, 2008 at 04:03:44PM +0100, Michal Hocko wrote: > > $ autoconf --version > > autoconf (GNU Autoconf) 2.61 > > > > config.{log,status} attached. > > These are from successfull run of autobuild after you have copied > install-sh into source root? > > Is there some ouput without install-sh? Okay please find attached output without install-sh script. config.status file was not created. Regards Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Michal H. <ms...@gm...> - 2008-01-28 10:21:37
|
On Mon, Jan 28, 2008 at 03:14:05PM +0530, Varun Hiremath wrote: > Hi Michal, > > On Mon, 28 Jan, 2008 at 09:53:25AM +0100, Michal Hocko wrote: > > > I have installed the latest gcc-4.3 package from sid. > > > > I have installed the one from testing: > > $ gcc-4.3 -v > > Using built-in specs. > > Target: i486-linux-gnu > > Configured with: ../src/configure -v --with-pkgversion='Debian 4.3-20080116-1' --with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.3 --program-suffix=-4.3 --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-targets=all --enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu --target=i486-linux-gnu > > Thread model: posix > > gcc version 4.3.0 20080116 (experimental) [trunk revision 131577] (Debian 4.3-20080116-1) > > Okay, I have the same version. Have you check that also --with-gxx-include matches? [...] > > Well, this is strange because I tried again on a remote machine > (amd64) with Debian testing installed and it failed with the same > error. Could you also please try on some other machine? Unfortunatelly, all my debian boxes are almost same, so the result is very same on all of them. Could you try (my output is attached): $ find /usr/include/c++/4.3 -name string /usr/include/c++/4.3/string /usr/include/c++/4.3/debug/string > > Regards > Varun > > -- > Varun Hiremath > Undergraduate Student, > Aerospace Engineering Department, > Indian Institute of Technology Madras, > Chennai, India > ------------------------------------- > Homepage: http://varun.travisbsd.org -- Michal Hocko |
From: Varun H. <var...@ii...> - 2008-01-28 12:38:48
|
Hi Michal, On Mon, 28 Jan, 2008 at 11:21:31AM +0100, Michal Hocko wrote: > Have you check that also --with-gxx-include matches? $$ g++-4.3 -v Using built-in specs. Target: i486-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Debian 4.3-20080116-1' --with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.3 --program-suffix=-4.3 --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-targets=all --enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu --target=i486-linux-gnu Thread model: posix gcc version 4.3.0 20080116 (experimental) [trunk revision 131577] (Debian 4.3-20080116-1) > Could you try (my output is attached): > $ find /usr/include/c++/4.3 -name string > /usr/include/c++/4.3/string > /usr/include/c++/4.3/debug/string $$ find /usr/include/c++/4.3 -name string /usr/include/c++/4.3/string /usr/include/c++/4.3/debug/string BTW, all the missing functions seem to be defined in /usr/include/c++/4.3/cstring file and /usr/include/c++/4.3/string file looks to be empty. Is there any particular reason why you would want to use string instead of cstring? Okay, few more things: 1) I had checked out the sources from cvs after you made the first announcement which was around 2 weeks back and I can't seem to checkout the sources again now because of some proxy issues. Have the sources changed during this duration which might be related to this? 2) Also the sources didn't have any configure script by default so I had to run makedist to generate configure script. I have no idea about these autoconf/autotools etc, so could you please make an unofficial tarball and mail it to me so that I could test again? 3) Apart from this I am using: export QTDIR=/usr/share/qt3 Regards Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Michal H. <ms...@gm...> - 2008-01-28 14:19:49
|
On Mon, Jan 28, 2008 at 06:24:46PM +0530, Varun Hiremath wrote: > Hi Michal, > > On Mon, 28 Jan, 2008 at 11:21:31AM +0100, Michal Hocko wrote: > > Have you check that also --with-gxx-include matches? > > $$ g++-4.3 -v > Using built-in specs. > Target: i486-linux-gnu > Configured with: ../src/configure -v --with-pkgversion='Debian 4.3-20080116-1' --with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.3 --program-suffix=-4.3 --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-targets=all --enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu --target=i486-linux-gnu > Thread model: posix > gcc version 4.3.0 20080116 (experimental) [trunk revision 131577] (Debian 4.3-20080116-1) Seems to be pretty same like my one. > > > Could you try (my output is attached): > > $ find /usr/include/c++/4.3 -name string > > /usr/include/c++/4.3/string > > /usr/include/c++/4.3/debug/string > > $$ find /usr/include/c++/4.3 -name string > /usr/include/c++/4.3/string > /usr/include/c++/4.3/debug/string > > BTW, all the missing functions seem to be defined in > /usr/include/c++/4.3/cstring file and /usr/include/c++/4.3/string > file looks to be empty. I have looked to my string and cstring files and string file is not empty (attached). > > Is there any particular reason why you would want to use string > instead of cstring? We have used include from string for a rather long time and there was no problem until now. I don't know difference between the 2 files. Nevertheless, I have done one more experiment. I have removed #include <string> from confparser.h and there is no problem at all. When I looked deeper, then it revealed that string is included from kernel/static.h which is included from almost all kernel files. If you didn't have problem with that then something is really wrong. Please do a new checkout, try it again and send me all output including configure log and compilation output if something goes wrong > > Okay, few more things: > > 1) I had checked out the sources from cvs after you made the first > announcement which was around 2 weeks back and I can't seem to > checkout the sources again now because of some proxy issues. Have the > sources changed during this duration which might be related to this? Yes, Jozo has committed some changes related to kernel/static.h header. I suggest to download current source from devel-msts-unified_makefiles branch which is close to be merged to the trunk (and will be part of next release). > > 2) Also the sources didn't have any configure script by default so I > had to run makedist to generate configure script. I have no idea about > these autoconf/autotools etc, so could you please make an unofficial > tarball and mail it to me so that I could test again? Yes. Configure is no more in CVS, because it is generated file and it is not in general to have such files in CVS. You can simply generate one by typing autoconf in the source tree root. If you have some problems though, use the attached one. > > 3) Apart from this I am using: > export QTDIR=/usr/share/qt3 Yes, that is correct. Debian doesn't export QTDIR by default AFAIK. > > Regards > Varun > > -- > Varun Hiremath > Undergraduate Student, > Aerospace Engineering Department, > Indian Institute of Technology Madras, > Chennai, India > ------------------------------------- > Homepage: http://varun.travisbsd.org -- Michal Hocko |
From: Varun H. <var...@ii...> - 2008-01-28 15:20:03
|
Hi Michal, On Mon, 28 Jan, 2008 at 03:19:42PM +0100, Michal Hocko wrote: > > > > BTW, all the missing functions seem to be defined in > > /usr/include/c++/4.3/cstring file and /usr/include/c++/4.3/string > > file looks to be empty. > > I have looked to my string and cstring files and string file is not empty > (attached). > > > > > Is there any particular reason why you would want to use string > > instead of cstring? > > We have used include from string for a rather long time and there was no > problem until now. I don't know difference between the 2 files. > Nevertheless, I have done one more experiment. I have removed > #include <string> from confparser.h and there is no problem at all. When > I looked deeper, then it revealed that string is included from > kernel/static.h which is included from almost all kernel files. > If you didn't have problem with that then something is really wrong. Okay, I got it. You seem to have kernel/static.h included in confparser.h, right? Here I didn't have it include so it was filaing to build but now I have included kernel/static.h and it builds. But, actually you are indirectly including cstring through the boost header files. In kernel/static.h you have: //============================================ // boost //============================================ #include <boost/smart_ptr.hpp> #include <boost/iostreams/stream.hpp> #include <boost/iostreams/filtering_stream.hpp> If you look at boost/iostreams/stream.hpp it has: #include <boost/iostreams/constants.hpp> #include <boost/iostreams/detail/char_traits.hpp> and now if you look at boost/iostreams/detail/char_traits.hpp: # include <boost/config.hpp> // Make sure size_t is in std. # include <cstddef> # include <cstring> <<=========== # include <cstdio> So, you can as well include cstring directly because the #include <string> is never used from kernel/static.h (you may remove it). It is this cstring which is included through boost headers that makes it work with gcc/g++ 4.3 Hope that ends all confusion. Regards Varun -- Varun Hiremath Undergraduate Student, Aerospace Engineering Department, Indian Institute of Technology Madras, Chennai, India ------------------------------------- Homepage: http://varun.travisbsd.org |
From: Michal H. <ms...@gm...> - 2008-01-28 16:14:39
|
On Mon, Jan 28, 2008 at 09:06:07PM +0530, Varun Hiremath wrote: > Hi Michal, > > On Mon, 28 Jan, 2008 at 03:19:42PM +0100, Michal Hocko wrote: > > > > > > BTW, all the missing functions seem to be defined in > > > /usr/include/c++/4.3/cstring file and /usr/include/c++/4.3/string > > > file looks to be empty. > > > > I have looked to my string and cstring files and string file is not empty > > (attached). > > > > > > > > Is there any particular reason why you would want to use string > > > instead of cstring? > > > > We have used include from string for a rather long time and there was no > > problem until now. I don't know difference between the 2 files. > > Nevertheless, I have done one more experiment. I have removed > > #include <string> from confparser.h and there is no problem at all. When > > I looked deeper, then it revealed that string is included from > > kernel/static.h which is included from almost all kernel files. > > If you didn't have problem with that then something is really wrong. > > > Okay, I got it. You seem to have kernel/static.h included in > confparser.h, right? Here I didn't have it include so it was filaing No, we are including it from confparser.cc, but this won't make any difference here. > to build but now I have included kernel/static.h and it builds. Could you try the latest CVS (from devel-msts-unified_makefiles branch)? Do you still have problem to get sources from there? I have just tried: cvs -z3 -d:pserver:ano...@pd...:/cvsroot/pdfedit \ co -r devel-msts-unified_makefiles pdfedit and didn't have any problems. > > But, actually you are indirectly including cstring through the boost > header files. In kernel/static.h you have: > > //============================================ > // boost > //============================================ > #include <boost/smart_ptr.hpp> > #include <boost/iostreams/stream.hpp> > #include <boost/iostreams/filtering_stream.hpp> > > > If you look at boost/iostreams/stream.hpp it has: > > #include <boost/iostreams/constants.hpp> > #include <boost/iostreams/detail/char_traits.hpp> > > and now if you look at boost/iostreams/detail/char_traits.hpp: > > # include <boost/config.hpp> // Make sure size_t is in std. > # include <cstddef> > # include <cstring> <<=========== > # include <cstdio> Yes, but note that these are included only if BOOST_IOSTREAMS_NO_STREAM_TEMPLATES is defined. I don't have any idea what is it... Nevertheless it is not clean to rely on including this header by boost headers, so it has to be sorted out. > So, you can as well include cstring directly because the #include > <string> is never used from kernel/static.h (you may remove it). It is > this cstring which is included through boost headers that makes it > work with gcc/g++ 4.3 Jozo, could you check if it is clear to add #include <cstring> into kernel/static.h instead of string? My quick test (cd src && make clean & make) was succesfull. > > Hope that ends all confusion. Thanks for your investigation. Just to be sure. Could you send me string from 4.3 and some older c++ directory? I still don't understand difference between those 2 files. All C++ manuals/books claims that #include <string> should be used when C++ strings are used. > > Regards > Varun > > -- > Varun Hiremath > Undergraduate Student, > Aerospace Engineering Department, > Indian Institute of Technology Madras, > Chennai, India > ------------------------------------- > Homepage: http://varun.travisbsd.org -- Michal Hocko |
From: Jozef M. <mis...@ho...> - 2008-01-28 16:50:37
|
found this http://www.efnetcpp.org/wiki/cstring_header =20 will change static.h. =20 static.h MUST be included from every source file in kernel to use precompil= ed headers.jozo > Date: Mon, 28 Jan 2008 17:14:24 +0100> From: ms...@gm...> To: varun= hir...@ii...> CC: pdf...@li...; misutkajunior= @hotmail.com> Subject: Re: [Pdfedit-devel] confparser gcc 4.3 compilation p= roblem> > On Mon, Jan 28, 2008 at 09:06:07PM +0530, Varun Hiremath wrote:> = > Hi Michal,> > > > On Mon, 28 Jan, 2008 at 03:19:42PM +0100, Michal Hocko = wrote:> > > > > > > > BTW, all the missing functions seem to be defined in>= > > > /usr/include/c++/4.3/cstring file and /usr/include/c++/4.3/string > = > > > file looks to be empty.> > > > > > I have looked to my string and cst= ring files and string file is not empty > > > (attached).> > > > > > > > > = > > Is there any particular reason why you would want to use string> > > > = instead of cstring?> > > > > > We have used include from string for a rathe= r long time and there was no> > > problem until now. I don't know differenc= e between the 2 files.> > > Nevertheless, I have done one more experiment. = I have removed > > > #include <string> from confparser.h and there is no pr= oblem at all. When> > > I looked deeper, then it revealed that string is in= cluded from> > > kernel/static.h which is included from almost all kernel f= iles. > > > If you didn't have problem with that then something is really w= rong.> > > > > > Okay, I got it. You seem to have kernel/static.h included = in> > confparser.h, right? Here I didn't have it include so it was filaing>= > No, we are including it from confparser.cc, but this won't make any> dif= ference here.> > > to build but now I have included kernel/static.h and it = builds. > > Could you try the latest CVS (from devel-msts-unified_makefiles= branch)?> Do you still have problem to get sources from there?> I have jus= t tried:> cvs -z3 -d:pserver:ano...@pd...:/cvsroot= /pdfedit \> co -r devel-msts-unified_makefiles pdfedit> > and didn't have a= ny problems.> > > > > But, actually you are indirectly including cstring th= rough the boost> > header files. In kernel/static.h you have:> > > > //=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D> > // boost> > //=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D> > #include <boost/s= mart_ptr.hpp>> > #include <boost/iostreams/stream.hpp>> > #include <boost/i= ostreams/filtering_stream.hpp>> > > > > > If you look at boost/iostreams/st= ream.hpp it has:> > > > #include <boost/iostreams/constants.hpp>> > #includ= e <boost/iostreams/detail/char_traits.hpp>> > > > and now if you look at bo= ost/iostreams/detail/char_traits.hpp:> > > > # include <boost/config.hpp> /= / Make sure size_t is in std.> > # include <cstddef>> > # include <cstring>= <<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D> > # include <cstdio>> > Yes, but note= that these are included only if> BOOST_IOSTREAMS_NO_STREAM_TEMPLATES is de= fined. I don't have any idea> what is it...> Nevertheless it is not clean t= o rely on including this header by> boost headers, so it has to be sorted o= ut.> > > So, you can as well include cstring directly because the #include>= > <string> is never used from kernel/static.h (you may remove it). It is> = > this cstring which is included through boost headers that makes it> > wor= k with gcc/g++ 4.3> > Jozo, could you check if it is clear to add #include = <cstring> into > kernel/static.h instead of string?> My quick test (cd src = && make clean & make) was succesfull.> > > > > Hope that ends all confusion= .> > Thanks for your investigation.> > Just to be sure. Could you send me s= tring from 4.3 and some older c++> directory? I still don't understand diff= erence between those 2 files.> All C++ manuals/books claims that #include <= string> should be used when> C++ strings are used.> > > > > Regards> > Varu= n> > > > -- > > Varun Hiremath> > Undergraduate Student,> > Aerospace Engin= eering Department,> > Indian Institute of Technology Madras,> > Chennai, In= dia> > -------------------------------------> > Homepage: http://varun.trav= isbsd.org> > -- > Michal Hocko _________________________________________________________________ Helping your favorite cause is as easy as instant messaging.=A0You IM, we g= ive. http://im.live.com/Messenger/IM/Home/?source=3Dtext_hotmail_join= |