Re: [Pcmanfm-develop] bug # 3462452

[Andrej N. G. <an...@re...>]

    Hello!

PCMan has written on Tuesday, 22 May, at  9:03:
>Thanks for the fixes. So, you're the user "lstranger"?
>Thanks a lot for helping the project.
>When the whole filename contains English strings without digits or special
>chars, the collect key is totally the same as the file basename. So, I did
>the same trick for collate_key. That's why it's not copied unconditionally.
>I need to recheck this part, though.

    It cannot be bound to name which is bound to another name or else you
should realloc it each time the second name is changed and that check
will consume more resources than that once-done allocation does. Not
counting the fact that disp_name can also be changed elsewhere so it's
always potential bug (remember it already was in mentioned bug report)
and also it's very unlikely the same string as people rarely have files
named with English-lower-case letters, especially not Englishmen. So at
least leave that collate_key be always allocated, it'll save you a lot of
troubles in the future. BTW, that memory consuming is very low compared
to all other stuff.

    Cheers!
    Andriy.