[Pcb-bugs] [Bug 1095516] Re: XY file rotations don't work for advanced SMD elements

[Traumflug <ma...@ju...>]

With this patch, the testsuite no longer passes. Apparently, all parts
are exported upside down. A line-by-line comparison:

    -R0_BOT,"Standard SMT resistor, capacitor etc","RESC3216N",600.00,3900.00,0,bottom
    +R0_BOT,"Standard SMT resistor, capacitor etc","RESC3216N",600.00,3900.00,180,bottom
    -R90_BOT,"Standard SMT resistor, capacitor etc","RESC3216N",1000.00,3900.00,90,bottom
    +R90_BOT,"Standard SMT resistor, capacitor etc","RESC3216N",1000.00,3900.00,270,bottom
    -R180_BOT,"Standard SMT resistor, capacitor etc","RESC3216N",1300.00,3900.00,180,bottom
    +R180_BOT,"Standard SMT resistor, capacitor etc","RESC3216N",1300.00,3900.00,0,bottom
    -R270_BOT,"Standard SMT resistor, capacitor etc","RESC3216N",1700.00,3900.00,270,bottom

Failing tests are hid_bom1...4.

-- 
You received this bug notification because you are a member of PCB Bug
Team, which is subscribed to pcb.
https://bugs.launchpad.net/bugs/1095516

Title:
  XY file rotations don't work for advanced SMD elements

Status in PCB: Printed Circuit Board CAD package:
  New

Bug description:
  BGA, PGA, and all packages with pin 1 in the top centre produce
  incorrect XY file rotations.

  Attached patch does the following:

  - Revises current rotation detection to match IPC-7351, as described
  in:  i.screamingcircuits.com/docs/understanding-the-centroid-
  file-r2-2.pdf

  - Looks for pins "A1","B1" etc as well as "1" & "2" to handle BGAs and
  PGAs

  - Looks for element attribute "xy-centre" which can be set to "origin"
  to use the element's origin, rather than the pin centroid as the
  centre reference point.   Needed to sensibly handle BGAs/PGAs with a
  single missing pin.

  - Looks for element attribute "xy-fixed-rotation" which can be used to
  force a given rotation, for when all else fails.

To manage notifications about this bug go to:
https://bugs.launchpad.net/pcb/+bug/1095516/+subscriptions