#1235 Fedora-21 build fails (pwsafe 0.95)

[John Ellson]

1) Missing BR for: wxGTK-devel

2) "rpmbuild --rebuild pwsafe-0.95BETA-3.src.rpm" fails with:

passwordsafeframe.cpp:2633:52: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"I\000\000\000m\000\000\000p\000\000\000o\000\000\000r\000\000\000t\000\000\000_\000\000\000T\000\000\000e\000\000\000x\000\000\000t\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
rpt.StartReport(_("Import_Text").c_str(), m_core.GetCurFile().c_str());
^
passwordsafeframe.cpp: In member function 'void PasswordSafeFrame::OnImportKeePass(wxCommandEvent&)':
passwordsafeframe.cpp:2736:63: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"I\000\000\000m\000\000\000p\000\000\000o\000\000\000r\000\000\000t\000\000\000_\000\000\000K\000\000\000e\000\000\000e\000\000\000P\000\000\000a\000\000\000s\000\000\000s\000\000\000V\000\000\0001\000\000\000_\000\000\000C\000\000\000S\000\000\000V\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
rpt.StartReport(("Import_KeePassV1_CSV").c_str(), m_core.GetCurFile().c_str());
^
passwordsafeframe.cpp:2738:63: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"I\000\000\000m\000\000\000p\000\000\000o\000\000\000r\000\000\000t\000\000\000_\000\000\000K\000\000\000e\000\000\000e\000\000\000P\000\000\000a\000\000\000s\000\000\000s\000\000\000V\000\000\0001\000\000\000_\000\000\000T\000\000\000X\000\000\000T\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
rpt.StartReport(_("Import_KeePassV1_TXT").c_str(), m_core.GetCurFile().c_str());
^
passwordsafeframe.cpp: In member function 'void PasswordSafeFrame::OnImportXML(wxCommandEvent&)':
passwordsafeframe.cpp:2842:51: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"I\000\000\000m\000\000\000p\000\000\000o\000\000\000r\000\000\000t\000\000\000\000\000\000X\000\000\000M\000\000\000L\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
rpt.StartReport(("Import_XML").c_str(), m_core.GetCurFile().c_str());
^
passwordsafeframe.cpp:2916:83: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"e\000\000\000n\000\000\000t\000\000\000r\000\000\000y\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
const TCHAR cs_validate = numValidated == 1 ? ("entry").c_str() : ("entries").c_str();
^
passwordsafeframe.cpp:2916:122: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"e\000\000\000n\000\000\000t\000\000\000r\000\000\000i\000\000\000e\000\000\000s\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
const TCHAR cs_validate = numValidated == 1 ? ("entry").c_str() : ("entries").c_str();
^
passwordsafeframe.cpp:2917:82: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"e\000\000\000n\000\000\000t\000\000\000r\000\000\000y\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
const TCHAR cs_imported = numImported == 1 ? ("entry").c_str() : ("entries").c_str();
^
passwordsafeframe.cpp:2917:121: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"e\000\000\000n\000\000\000t\000\000\000r\000\000\000i\000\000\000e\000\000\000s\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
const TCHAR cs_imported = numImported == 1 ? ("entry").c_str() : ("entries").c_str();
^
passwordsafeframe.cpp: In member function 'void PasswordSafeFrame::Merge(const StringX&, PWScore, const SelectionCriteria&)':
passwordsafeframe.cpp:3232:46: error: request for member 'c_str' in 'wxGetTranslation(((const wchar_t)"M\000\000\000e\000\000\000r\000\000\000g\000\000\000e\000\000\000\000\000\000"), 0u)', which is of non-class type 'const wxChar {aka const wchar_t}'
rpt.StartReport(("Merge").c_str(), m_core.GetCurFile().c_str());

[Saurav Ghosh]

Is this with wxWidgets2.8? Pwsafe requires wx3.

[John Ellson]

Yes, the dependency is on wxGTK-devel (2.8) because the Makefile uses /usr/bin/wx-config. To use wx3 on Fedora, it should use /usr/bin/wx-config-3.0
from the wxGTK3-devel package.

[Rony Shapiro]

Fixed in commit 40406a5:
- Document requirement for wxGTK3-devel in Fedora
- Add wxGTK3-devel as a build prerequisite in rpm spec
- Set Makefiles to look for wx-config-3.0 first, default to wx-config if not found (but still overridable by external WX_CONFIG)