#1213 Changing password policy destroys common options

[Joris van Rantwijk]

On Linux, editing the default password policy causes unexpected changes in general options.

For example:
1. [Manage] -> [Options] -> [Save database immediately] is initially checked.
2. Go to [Manage] -> [Password Policies] -> [Edit]. Change the password length.
3. [Manage] -> [Options] -> [Save database immediately] is now spontaneously unchecked.

[Saurav Ghosh]

We need more details. Which version of the software is this, running on which platform?

I tried to reproduce from latest sources, and couldn’t. More steps would be helpful. For example, did you click Ok and close the dialog after step 2? Or did you just shift to the Backups tab? Things like those...

[Rony Shapiro]

Note that Joris provided a patch for this in a forked repository:

Joris van Rantwijk has requested that you merge changes from git://git.code.sf.net/u/jvrantwijk/passwordsafe (6d9737d8d561d3282b6f533645264e22d6ad3bc6) into the branch master

On Linux, changing the default password policy uses the copied PWSprefs to write changes to the database.

This patch adds a call to SetupCopyPrefs() to avoid overwriting the non-policy prefs with uninitialized values.

I plan to review the patch this evening (UTC+3), but would welcome any inputs.

[Joris van Rantwijk]

I'm running yesterday's git snapshot on Debian GNU/Linux 7.6.
The same issue occurs when running 0.94BETA.

The exact steps are as follows:
* start application
* open [Manage] -> [Options]
* verify that [Save immediately] is checked
* click [Cancel] to close options dialog (this may be important)
* click [Manage] -> [Password Policies]
* I have only one password policy: the default policy
* click [Edit]
* change the password length
* click [Ok] to confirm the policy edit
* click [Ok] to close the password policy manager
* open [Manage] -> [Options]
* note that [Save immediately] is now unchecked

[Rony Shapiro]

Fixed by submitter, commit 16cba8cc308acdb3328c71bb2d126ea7b6de5384 - thanks!