From: Pablo d'A. <pab...@we...> - 2007-01-01 19:11:14
|
Hi all, I have noticed that PTmender does not overwrite existing files. Maybe it would be a good idea to add a -f flag, to force overwriting the output files, similar to other tools. The root cause is that the rename() function only works if the destination file does not exist. ciao Pablo |
From: Daniel M. G. <dm...@uv...> - 2007-01-01 20:10:15
|
Hi Pablo, Pablo d'Angelo twisted the bytes to say: Pablo> Hi all, Pablo> I have noticed that PTmender does not overwrite existing files. Maybe it Pablo> would be a good idea to add a -f flag, to force overwriting the output Pablo> files, similar to other tools. Pablo> The root cause is that the rename() function only works if the destination Pablo> file does not exist. Unfortunately it is operating system dependent (which is bad news, see below). Under Posfix it should remove the file first. That means that under Unixes PTmender does replace the older files. If we are to be consistent, PTmender should not overwrite output files by default. But the other tools do the opposite. Does anybody know what is the behaviour of PTstitcher under Windows? dmg ---------------------------------------------------------------------- DESCRIPTION Rename() causes the link named from to be renamed as to. If to exists, it is first removed. Both from and to must be of the same type (that is, both directories or both non-directories), and must reside on the same file system. Rename() guarantees that an instance of to will always exist, even if the system should crash in the middle of the operation. If the final component of from is a symbolic link, the symbolic link is renamed, not the file or directory to which it points. ---------------------------------------------------------------------- Pablo> ciao Pablo Pablo> ------------------------------------------------------------------------- Pablo> Take Surveys. Earn Cash. Influence the Future of IT Pablo> Join SourceForge.net's Techsay panel and you'll get the chance to share your Pablo> opinions on IT & business topics through brief surveys - and earn cash Pablo> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV Pablo> _______________________________________________ Pablo> PanoTools-devel mailing list Pablo> Pan...@li... Pablo> https://lists.sourceforge.net/lists/listinfo/panotools-devel -- Daniel M. German "The likings and dislikings of society, or of some powerful portion of it, are thus the main thing which has practically determined the rules laid down for general observance,\under the penalties of law or opinion." John Stuart Mill http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: Pablo d'A. <pab...@we...> - 2007-01-01 22:48:52
|
Hi Daniel, > Pablo d'Angelo twisted the bytes to say: > > Pablo> Hi all, > Pablo> I have noticed that PTmender does not overwrite existing files. Maybe it > Pablo> would be a good idea to add a -f flag, to force overwriting the output > Pablo> files, similar to other tools. > > Pablo> The root cause is that the rename() function only works if the destination > Pablo> file does not exist. > > Unfortunately it is operating system dependent (which is bad news, see > below). Under Posfix it should remove the file first. That means that > under Unixes PTmender does replace the older files. I have added code that checks if a file exists and removes it before calling rename. Then the outcome should at least be platform independant. > If we are to be consistent, PTmender should not overwrite output files > by default. But the other tools do the opposite. I don't have a real opinion for or against overwriting the output files by default. However the tools have a consistent behaviour. > Does anybody know what is the behaviour of PTstitcher under Windows? I'm not sure anymore, but I believe it just overwrote the output files. ciao Pablo |