From: Boris Z. <bo...@am...> - 2003-10-13 10:38:51
|
Hi, Am Montag, 13. Oktober 2003 11:40 schrieb Rob Starkey: > ----- Original Message ----- > From: "Boris Zentner" <bo...@am...> > To: "Rob Starkey" <fa...@ra...>; [...] > > > machine has perl 5.8.x installed. the patch should only applied to perl > > >= 5.8.x and pagekit <= 1.11. > > Ah... ok. I see. Though, maybe instead of not installing a patch only > when 5.8.x is detected, why not patch the code and use 'if' and $] to do > the right thing if the perl version is > 5.008? That way you only have ONE > version of 1.12 going around. I wish I had time to help rework the patch > but I hardly have enough time to sleep. :) > That was my first idea, but I noticed that the versions are very different. And the test is done several times per request over and over. So I came up with the patch idea. For the new version of pagekit I put the patch into the Makefile.PL and apply it to the blib directory during the make phase. This way we have only one copy for both versions of perl. I'm not really sure if this is the best way since up to my knowlage we are the only module that has eventualy different files in lib and blib/lib. But MakeMaker allowed filters that produce different versions too and so I sure it is at least supported. The drawback is a ugly makefile and the need of the patch command for perl 5.8 at the installation process. > As a side note, I'm working on a new project that I'm using pagekit, 5.8.1 > and 5 different langauges, thanks for the patch, I'm sure I'll find it > quite useful when the translations come back. > ;-) > > Have a nice day. > > Ditto. > > > Rob > -- Boris |