Menu
▾
▴
Re: [Pagekit-devel] Wish: PKIT_EDIT_LINKS
|
From: Erik G. <er...@bo...> - 2004-03-22 15:07:47
|
m=E5n 2004-03-22 klockan 16.06 skrev Boris Zentner:
> Hi Erik,
>=20
> Am Montag, 22. M=E4rz 2004 13:15 schrieb Erik Gunther:
> > m=E5n 2004-03-22 klockan 12.32 skrev Boris Zentner:
> > > Hi Erik,
> > >
> > > I think on your suggestions, but so far I do not get it all.
> > >
> > > Am Sonntag, 21. M=E4rz 2004 18:56 schrieb Erik G=FCnther:
> > > > The reason to not to generate a hole link are as shown in the examp=
le
> > > > that pagekit might not be the have control over the hole site (In m=
y
> > > > site I have two apache servers, one with and one without mod_perl).
> > >
> > > Does uri_prefix in Config.xml slove or ease your problem? I just test=
it
> > > and there is a bug that is fixed with the attached patch.
> >
> > Yes... or somewhat.That whould get the correct links. But the links wil=
l
> > still get all over the place. Due to the fact that som links gets
>=20
> Thats fine, thanks for finding that bug. So you agree with me to apply th=
e=20
> patch to the next PageKit release?
>=20
> > pressentet first (before <html>) and other where the call for a
> > commponent are. And the layout I have om my page the links will get
> > placed under some (non transparent) layers and over other edit-links.
> >
> > Therefore I would like to collect all the edit links and place them
> > whitin the layout. And the PKIT_EDIT_PLACEHOLER whould do the trick for
> > me. I'm open for other sullotions that do about the same thing (like th=
e
> > MESSAGE and ERROR but I do like the MESSAGE aproche better.) If you hav=
e
> > a simpel layout it dosen't matter that mutch but in a more advanced it
> > does. And I plan to use the edit-links quite active so it whould help m=
y
> > do a niceer page.
> >
> > If you like to see I can send you a file containing a page with
> > edit-links, showing my problem. But that will be to night, my time :)
>=20
> I know about the problem, but it did not hurt me so far.=20
> I like to see a picture just for the case, that I missed something.
>=20
> >
> > And I have no problem with applaying this diff. (I acctually use
> > pkit_output_filter now and check if I'm within pkit_admin mode :) )
> >
> > PS And with the PKIT_EDIT_PALCEHOLDER-tagg I can have pages that are
> > valid XHTML1.1 even when pkit_admin=3Don ;) DS
>=20
> I try to build a preview of your edit link proposal tomorrow. I follow yo=
ur=20
> first mail roughly.
>=20
> Perhaps we can use <PKIT_EDIT_COMPONENT NAME=3D"xxx"/> as a nop unless=20
> pkit_admin=3D1.
>=20
> If pkit_admin=3D1 include the component and build the edit links.
> If pkit_admin=3D1 and PKIT_EDIT_COMPONENT is missed, then do it as before=
.
>=20
No problem, seams like a good idea.
> But what if we have some parts ( files or components ) more then once? Sh=
ould=20
> they get merged or not?
In my opinion: merged.=20
--=20
/erikg=20
=20
Erik G=FCnther eri...@bo...
System Developer Bokus AB
+46 (0)40 - 35 21 19 icq: 160744619 =
=20
=20
Fortune:
Never keep up with the Joneses. Drag them down to your level.
-- Quentin Crisp
|