From: Chenjie <ch...@le...> - 2009-10-14 13:52:32
Attachments:
loongson_support.patch
|
Hi all, This patch adds oprofile userland support for loongson 2 processor. The kernel part of oprofile support has already entered mainline (see http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=67b35e5d01aba7a83f2161b0c90acb08afa01e3e) To try this, you may additionally need a patch which fix broken o32 lookup_dcookie syscall with a 64-bit kernel (see http://www.linux-mips.org/archives/linux-mips/2009-10/msg00089.html), since most linux system running on loongson platform will have a 64-bit kernel with a o32 userland, == summary of the patch == events/Makefile.am | 1 + events/mips/godson2/events | 34 ++++++++++++++++++++++++++++++++++ events/mips/godson2/unit_masks | 4 ++++ events/mips/loongson2/events | 1 + events/mips/loongson2/unit_masks | 1 + libop/op_cpu_type.c | 1 + libop/op_cpu_type.h | 1 + libop/op_events.c | 1 + libutil/op_cpufreq.c | 5 +++++ utils/ophelp.c | 5 +++++ 10 files changed, 54 insertions(+), 0 deletions(-) create mode 100644 events/mips/godson2/events create mode 100644 events/mips/godson2/unit_masks create mode 100644 events/mips/loongson2/events create mode 100644 events/mips/loongson2/unit_masks |
From: Maynard J. <may...@us...> - 2009-10-20 14:08:55
|
Chenjie wrote: > Hi all, > This patch adds oprofile userland support for loongson 2 processor. > The kernel part of oprofile support has already entered mainline (see > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=67b35e5d01aba7a83f2161b0c90acb08afa01e3e) > > To try this, you may additionally need a patch which fix broken o32 > lookup_dcookie syscall with a 64-bit kernel (see > http://www.linux-mips.org/archives/linux-mips/2009-10/msg00089.html), > since most linux system running on loongson platform will have a > 64-bit kernel with a o32 userland, Thanks for your patch submission. I have a few requests regarding your submission. First, please add a Signed-off-by line to your patch submission, as described at http://oprofile.sourceforge.net/contribute/. Also, include a ChangeLog entry as described in the <oprofile-src>/HACKING file. Could you explain why you have loongson2 events and unit masks including godson2 events and unit masks instead of just putting the event/unit mask info directly into the loongson2 files. Lastly, 'make distcheck' fails with: "could not open unit mask description file ../../../events/mips/godson2/unit_masks" Please fix that error. Thanks. -Maynard > > == summary of the patch == > events/Makefile.am | 1 + > events/mips/godson2/events | 34 ++++++++++++++++++++++++++++++++++ > events/mips/godson2/unit_masks | 4 ++++ > events/mips/loongson2/events | 1 + > events/mips/loongson2/unit_masks | 1 + > libop/op_cpu_type.c | 1 + > libop/op_cpu_type.h | 1 + > libop/op_events.c | 1 + > libutil/op_cpufreq.c | 5 +++++ > utils/ophelp.c | 5 +++++ > 10 files changed, 54 insertions(+), 0 deletions(-) > create mode 100644 events/mips/godson2/events > create mode 100644 events/mips/godson2/unit_masks > create mode 100644 events/mips/loongson2/events > create mode 100644 events/mips/loongson2/unit_masks > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > > > ------------------------------------------------------------------------ > > _______________________________________________ > oprofile-list mailing list > opr...@li... > https://lists.sourceforge.net/lists/listinfo/oprofile-list |
From: Chen J. <ch...@le...> - 2009-10-21 13:46:53
Attachments:
loongson_support_v2.patch
|
The second version of patch adds oprofile userland support for ICT loongson2 processor. Signed-off-by Chen Jie <ch...@le...> == changes since patch v1 == * Fix 'make distcheck' fails * Add new entry to ChangeLog About godson2 and loongson2: godson is the codename, and loongson is the trademark, using "loongson" is perferred. The relationship may like Nehalem and core i7. Currently, the kernel identifies loongson2 as "mips/godson2" (arch/mips/oprofile/op_model_loongson2.c), so I put the substantial content in godson2 events, and let loongson2 events include it. Thanks, -Chen |
From: Maynard J. <may...@us...> - 2009-10-21 14:10:07
|
Chen Jie wrote: > The second version of patch adds oprofile userland support for ICT > loongson2 processor. > Signed-off-by Chen Jie <ch...@le...> > > == changes since patch v1 == > * Fix 'make distcheck' fails > * Add new entry to ChangeLog > > About godson2 and loongson2: > godson is the codename, and loongson is the trademark, using > "loongson" is perferred. > The relationship may like Nehalem and core i7. > > Currently, the kernel identifies loongson2 as "mips/godson2" > (arch/mips/oprofile/op_model_loongson2.c), so I put the substantial > content in godson2 events, and let loongson2 events include it. This seems wrong. The way you explain it, this is *not* analogous to Nehalem. For the Nehalem-based processors, the oprofile kernel driver reports their cpu_type as the specific type; e.g. "i386/core_i7". The event info is put into the events/i386/nehalem/events file, and then events/i386/core_i7/events file simply includes the nehalem events file. If the kernel reports the processor as "mips/godson2", then all you need is the godson2 events file. I don't see where the loongson2 events file would ever come into play. Did you run 'make distcheck'? This must pass before your patch can be accepted. Regards, -Maynard > > Thanks, > -Chen > |
From: Chen J. <ch...@le...> - 2009-10-21 14:24:05
|
2009/10/21 Maynard Johnson <may...@us...>: > Chen Jie wrote: >> The second version of patch adds oprofile userland support for ICT >> loongson2 processor. >> Signed-off-by Chen Jie <ch...@le...> >> >> == changes since patch v1 == >> * Fix 'make distcheck' fails >> * Add new entry to ChangeLog >> >> About godson2 and loongson2: >> godson is the codename, and loongson is the trademark, using >> "loongson" is perferred. >> The relationship may like Nehalem and core i7. >> >> Currently, the kernel identifies loongson2 as "mips/godson2" >> (arch/mips/oprofile/op_model_loongson2.c), so I put the substantial >> content in godson2 events, and let loongson2 events include it. > This seems wrong. The way you explain it, this is *not* analogous to Nehalem. For the Nehalem-based processors, the oprofile kernel driver reports their cpu_type as the specific type; e.g. "i386/core_i7". The event info is put into the events/i386/nehalem/events file, and then events/i386/core_i7/events file simply includes the nehalem events file. If the kernel reports the processor as "mips/godson2", then all you need is the godson2 events file. I don't see where the loongson2 events file would ever come into play. Did you run 'make distcheck'? This must pass before your patch can be accepted. I've ran 'make distcheck', no error reports. Currently only a few parts in kernel source reference "loongson" as "godson", these will be changed to "loongson" in the future. > > Regards, > -Maynard > >> >> Thanks, >> -Chen >> > > |
From: John L. <le...@mo...> - 2009-10-21 14:28:24
|
On Wed, Oct 21, 2009 at 10:23:14PM +0800, Chen Jie wrote: > I've ran 'make distcheck', no error reports. > Currently only a few parts in kernel source reference "loongson" as > "godson", these will be changed to "loongson" in the future. Then you need to finish fixing the kernel before trying to work around it in userspace, unless you can convince us otherwise... regards john |
From: Chen J. <ch...@le...> - 2009-10-22 00:57:11
|
John, Maynard: Thanks for your reviews and suggestions, a patch fixing the kernel (rename cpu_type from godson2 to loongson2) is submitted (see http://www.linux-mips.org/archives/linux-mips/2009-10/msg00293.html) I'll submit another version of this patch removing the godson2/events once the kernel patch is applied. Regards, - Chen 2009/10/21 John Levon <le...@mo...>: > On Wed, Oct 21, 2009 at 10:23:14PM +0800, Chen Jie wrote: > >> I've ran 'make distcheck', no error reports. >> Currently only a few parts in kernel source reference "loongson" as >> "godson", these will be changed to "loongson" in the future. > > Then you need to finish fixing the kernel before trying to work around > it in userspace, unless you can convince us otherwise... > > regards > john > |
From: Chen J. <ch...@le...> - 2009-11-04 01:15:31
Attachments:
loongson_support_v3.patch
|
Adds oprofile userland support for ICT loongson2 processor. Signed-off-by Chen Jie <ch...@le...> This is the third version, changes since last version: * unify the cpu's identifier, rename from "godson2" to "loongson2" (This needs kernel support: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=55f4e1d4fe88f16f773ba5bb31ce8c1ae63724af ) The 'make distcheck' test is ok. Regards, - Chenj |
From: Maynard J. <may...@us...> - 2009-11-25 20:36:26
|
Chen Jie wrote: > Adds oprofile userland support for ICT loongson2 processor. > Signed-off-by Chen Jie <ch...@le...> > > This is the third version, changes since last version: > * unify the cpu's identifier, rename from "godson2" to "loongson2" (This > needs kernel support: > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=55f4e1d4fe88f16f773ba5bb31ce8c1ae63724af > ) > > The 'make distcheck' test is ok. Patch committed. Thanks. -Maynard > > > Regards, > - Chenj > > |