Re: [PATCH] adds support for loongson2

[Maynard J. <may...@us...>]

Chenjie wrote:
> Hi all,
> This patch adds oprofile userland support for loongson 2 processor.
> The kernel part of oprofile support has already entered mainline (see
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=67b35e5d01aba7a83f2161b0c90acb08afa01e3e)
> 
> To try this, you may additionally need a patch which fix broken o32
> lookup_dcookie syscall with a 64-bit kernel (see
> http://www.linux-mips.org/archives/linux-mips/2009-10/msg00089.html),
> since most linux system running on loongson platform will have a
> 64-bit kernel with a o32 userland,
Thanks for your patch submission.  I have a few requests regarding your submission.

First, please add a Signed-off-by line to your patch submission, as described at 
http://oprofile.sourceforge.net/contribute/.  Also, include a ChangeLog entry as 
described in the <oprofile-src>/HACKING file.

Could you explain why you have loongson2 events and unit masks including godson2 
events and unit masks instead of just putting the event/unit mask info directly 
into the loongson2 files.

Lastly, 'make distcheck' fails with:
"could not open unit mask description file ../../../events/mips/godson2/unit_masks"
Please fix that error.

Thanks.
-Maynard
> 
> == summary of the patch ==
>  events/Makefile.am               |    1 +
>  events/mips/godson2/events       |   34 ++++++++++++++++++++++++++++++++++
>  events/mips/godson2/unit_masks   |    4 ++++
>  events/mips/loongson2/events     |    1 +
>  events/mips/loongson2/unit_masks |    1 +
>  libop/op_cpu_type.c              |    1 +
>  libop/op_cpu_type.h              |    1 +
>  libop/op_events.c                |    1 +
>  libutil/op_cpufreq.c             |    5 +++++
>  utils/ophelp.c                   |    5 +++++
>  10 files changed, 54 insertions(+), 0 deletions(-)
>  create mode 100644 events/mips/godson2/events
>  create mode 100644 events/mips/godson2/unit_masks
>  create mode 100644 events/mips/loongson2/events
>  create mode 100644 events/mips/loongson2/unit_masks
> 
> 
> ------------------------------------------------------------------------
> 
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay 
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> oprofile-list mailing list
> opr...@li...
> https://lists.sourceforge.net/lists/listinfo/oprofile-list