Menu
▾
▴
[ oprofile-Bugs-840046 ] opd_parse_kernel_range(NULL) called with --no-vmlinux
|
From: SourceForge.net <no...@so...> - 2003-11-12 18:35:37
|
Bugs item #840046, was opened at 2003-11-11 15:55 Message generated for change (Comment added) made by movement You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=116191&aid=840046&group_id=16191 Category: None Group: None >Status: Closed Resolution: Fixed Priority: 7 Submitted By: Joseph VanAndel (vanandel) Assigned to: Philippe Elie (phil_e) Summary: opd_parse_kernel_range(NULL) called with --no-vmlinux Initial Comment: oprofiled crashes on startup with --no-vmlinux . It calls opd_parse_kernel_range(kernel_range), with kernel_range=0 (RH 9, vmlinux 2.4.22, gcc 3.3.2) Both CVS version and oprofile-0.7 have same bug. For oprofile-0.7: the fix is: diff -c oprofiled.c.orig oprofiled.c *** oprofiled.c.orig 2003-11-11 08:43:03.000000000 -0700 --- oprofiled.c 2003-11-11 08:44:19.000000000 -0700 *************** *** 361,367 **** opd_options(argc, argv); ! opd_parse_kernel_range(kernel_range); opd_buf_size = opd_read_fs_int("bufsize"); opd_note_buf_size = opd_read_fs_int("notesize"); --- 361,367 ---- opd_options(argc, argv); ! if (!no_vmlinux) opd_parse_kernel_range(kernel_range); opd_buf_size = opd_read_fs_int("bufsize"); opd_note_buf_size = opd_read_fs_int("notesize"); ---------------------------------------------------------------------- >Comment By: John Levon (movement) Date: 2003-11-12 18:35 Message: Logged In: YES user_id=53034 Fixed in 0.7.1 ---------------------------------------------------------------------- Comment By: Philippe Elie (phil_e) Date: 2003-11-11 16:22 Message: Logged In: YES user_id=318973 ouch, checking for !no_vmlinux was lost during code reorganization, thanks for the report and the fix, I adapted your patch to CVS. regards, Phil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=116191&aid=840046&group_id=16191 |