From: William C. <wc...@nc...> - 2003-03-03 05:09:53
|
Here is the patch that I forgot to attach. -Will William Cohen wrote: > I converted my patch for the itanium 2 events to the new event format. I > found a some problems with the op_events.c/op_events.h code. I have a > patch to fix one of the problems with the checking of the unit_mask: > > 2003-03-03 Will Cohen <wc...@re...> > > * libop/op_events.h: > * libop/op_events.c: Correct checking for the number of unit > masks. > > It would be really helpful for the events.c error messages to indicate > the file and the line number that the parse error occurred, so that it > becomes trivial for developer to go directly to the line with the error, > e.g. like gcc error messages. > > The parser doesn't really handle white spaces. Put more than one space > between descriptions tags on a line. For example the following is a > single line that the parse will have problems with " counters": > > event:0x06 counters:0,1,2,3 um:zero minimum:5000 name:FP_FAILED_FCHKF : > Failed fchkf > > It would be nice for op_help to print out the choices of processors that > it can print out events for. Would it be possible to have it accept > strings in addition to the numbers ala the /dev/oprofile/cpu_type patch? > > -Will > > John Levon wrote: > >> I have completed the tedious job of moving the descriptions >> into a parsed text file. Please all of you have a look at the FIXMEs >> within those files, and fix any mistakes you may spot. >> >> Also, please try it out. >> >> regards >> john >> >> >> ------------------------------------------------------- >> This sf.net email is sponsored by:ThinkGeek >> Welcome to geek heaven. >> http://thinkgeek.com/sf >> _______________________________________________ >> oprofile-list mailing list >> opr...@li... >> https://lists.sourceforge.net/lists/listinfo/oprofile-list >> > > > |