Re: opcontrol --deinit

[William C. <wc...@nc...>]

Okay, here is the latest revision of the patch that includes the "return 
0;" at the end of do_dump. okay to check in?

-Will

Philippe Elie wrote:
> William Cohen wrote:
> 
>>
>>
>> Philippe Elie wrote:
>>
>>> William Cohen wrote:
>>>
>>>> I noticed that "opcontrol --deinit" only works if a daemon was 
>>>> already running. --deinit should shut things down, remove the module 
>>>> regardless of whether the daemon is running. Here is a patch that 
>>>> still returns an error condition if the dump doesn't work for 
>>>> "opcontrol --dump", but it allows the --deinit and other options to 
>>>> work even if the daemon is gone.
>>>>
>>>> 2003-02-06  Will Cohen  <wc...@re...>
>>>>
>>>>     * utils/opcontrol (do_dump): Do not exit if no daemon.
>>>
>>>
>>>
>>>
>>>
>>> ok, it's needed but isn't better to:
>>
>>
>>
>> I am not an expert in shell programming; I didn't realize that return 
>> could actually return a value. I revised the patch. Rather than trying 
>> to wrap the messages in the do_dump() I just moved the message into 
>> the place where the exit 1 now occurs. It seemed to make more sense.
> 
> 
> make sense. A last bit and you can commit it, at the end of
> do_dump you need a return 0; iirc if return is missing the
> return value is the last command status but you probably don't
> itend to do that.
> 
> thanks,
> Phil
> 
> 
> 
> -------------------------------------------------------
> This SF.NET email is sponsored by:
> SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
> http://www.vasoftware.com
> _______________________________________________
> oprofile-list mailing list
> opr...@li...
> https://lists.sourceforge.net/lists/listinfo/oprofile-list
>