Re: Graydon/Will - P4 HT changes, cpu_type

[Philippe E. <ph...@wa...>]

graydon hoare wrote:
> On Fri, 2003-01-10 at 18:01, John Levon wrote:
> 
>>oCan I get a patch for the libop/op_events etc.  changes for P4 HT
>>please, so I can submit the P4 patch in 2.5 ?
> 
> 
> I *thought* that was part of one or another of the patches I sent
> already. all it actually involved was changing the order of the counter
> numbers in p4, and flagging those events which are HT-supportable.
> 


> --- libop/op_events.c	Wed Nov 13 23:12:51 2002
> +++ libop/op_events.c	Mon Dec  2 04:56:05 2002
> @@ -343,6 +343,7 @@
>  #define OP_IA_ALL	(OP_PII_PIII | OP_PPRO)
>  
>  #define OP_P4           (1 << CPU_P4)
> +#define OP_P4_HT2       ((1 << CPU_P4) | (1 << CPU_P4_HT2))


>    /* pentium 4 events */
> -  { CTR_IQ_ALL,    OP_P4, 0x01, &um_branch_retired, "BRANCH_RETIRED", 
> +  { CTR_IQ_ALL,    OP_P4_HT2, 0x01, &um_branch_retired, "BRANCH_RETIRED", 

naming is slightly confusing, at a first read I though it was
HT specific event and later in file I will find the P4 event,
can you change the def on OP_P4_HT2, add #define OP_P4_ALL
and use it instead of OP_P4_HT2


regards,
Phil