From: William C. <wc...@nc...> - 2002-09-20 20:39:15
|
One of the concerns is being able to compile this on older kernels. The 2.4.18 kernel doesn't appear to have the MSR_P6_* defined. The code needs to compile on earlier versions of the kernel. If the values are the same (they should be), I would leave the names the same. I tried the patch on P3 and athlon and driver didn't work. :( I verified that the unpatched version of oprofile I used worked, so there is something in the patch that isn't right. I don't know what right now. -Will gr...@re... wrote: > At Fri, 20 Sep 2002 14:34:20 -0400, > William Cohen wrote: > > >>module/x86/op_model_ppro.c is missing a: >> >>#include "op_msr.h" > > > Ha! nice catch. it *is* missing, but I wondered how it could possibly > compile without that. it seems that > > /usr/src/linux-2.4.19/include/asm/msr.h > > includes these lines too: > > #define MSR_P6_PERFCTR0 0xc1 > #define MSR_P6_PERFCTR1 0xc2 > #define MSR_P6_EVNTSEL0 0x186 > #define MSR_P6_EVNTSEL1 0x187 > > should we change the #defines we're using, or should I just put in the > apporiate #include "op_msr.h" and have it not-override the kernel > definitions? > > -graydon > |