exits

[William C. <wc...@nc...>]

I was playing around with oprof_report looking and a set of samples that 
were collected earlier. Unfortunately, some of the executables had been 
removed. I was surprised when I attempted to open one of the sample 
files for a non-existent executable and oprof_report exited. It looks 
like many of the functions in pp/oprofpp_util.cpp just exit if there is 
a problem leaving the entire program. That isn't very desirable 
behavior. Someone makes a mistake and oprof_report has to be restarted. 
Shouldn't the code in pp/oprofpp_util.cpp be throwing exceptions instead 
of just deciding to exit? The oprof_report can print an appropriate 
error message and the let the user try again.

Another minor thing is I noticed that "exit(1);" was used in 
gui/oprof_start.cpp and gui/oprof_start_util.cpp. These should probably 
be "exit(EXIT_FAILURE);". You never know when someone will decide to 
port this code to an operating system where "exit(1)" means something 
other than a failure.

-Will