[ oprofile-Bugs-3448699 ] Nr. non-backtrace samples in oprofiled.log is not accurate

[SourceForge.net <no...@so...>]

Bugs item #3448699, was opened at 2011-12-02 16:22
Message generated for change (Settings changed) made by maynardj
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116191&aid=3448699&group_id=16191

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: Fixed
Priority: 7
Private: No
Submitted By: Maynard Johnson (maynardj)
Assigned to: Maynard Johnson (maynardj)
Summary: Nr. non-backtrace samples in oprofiled.log is not accurate

Initial Comment:
The Nr. non-backtrace samples is tracked in the daemon code with opd_stats[OPD_SAMPLES].  This value is incremented every time sfile_find() is called from opd_put_sample().  However, if we're processing samples for which the sfile has already been found, then trans->current will be set, and thus we will not call sfile_find again.  In fact, there are several statistics counters managed in sfile_find that should probably be managed from opd_put_sample.

----------------------------------------------------------------------

Comment By: Maynard Johnson (maynardj)
Date: 2012-07-20 08:34

Message:
Patch committed on July 20.

----------------------------------------------------------------------

Comment By: Maynard Johnson (maynardj)
Date: 2012-07-19 07:14

Message:
It turns out that only the OPD_SAMPLES stat was being incremented in the
wrong place.  The other stats that are incremented in sfile_find() are
within if-statements where we could only reach that code if trans.current
was NULL in opd_put_samples and we then had to call sfile_find().

I posted a patch for this problem to the list.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116191&aid=3448699&group_id=16191